From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nf-next:nf_tables-experiments PATCH 3/4] nf_tables: Add support for IPv6 NAT expression
Date: Thu, 15 Nov 2012 14:44:27 +0200 [thread overview]
Message-ID: <50A4E3AB.3080703@linux.intel.com> (raw)
In-Reply-To: <20121115122908.GB2271@1984>
Hi Pablo,
>> #include <linux/netfilter_ipv4.h>
>> >@@ -26,8 +27,10 @@
>> > #include <net/ip.h>
>> >
>> > struct nft_nat {
>> >- enum nft_registers sreg_addr_min:8;
>> >- enum nft_registers sreg_addr_max:8;
>> >+ enum nft_registers sreg_addr_min_v4:8;
>> >+ enum nft_registers sreg_addr_max_v4:8;
>> >+ enum nft_registers sreg_addr_min_v6:8;
>> >+ enum nft_registers sreg_addr_max_v6:8;
> Suggestion: Couldn't we get this patch a bit smaller by adding int
> family and the NFTA_NAT_FAMILY attribute?
Why not, at least semantically it could look better indeed, though from
struct size point of view it won't change anything.
The logic for parsing NFTA would be easier too.
Let's do this.
Tomasz
next prev parent reply other threads:[~2012-11-15 12:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 9:15 [nf-next:nf_tables-experiments PATCH 0/4] NAT expression and IPv6 NAT support Tomasz Bursztyka
2012-11-15 9:15 ` [nf-next:nf_tables-experiments PATCH 1/4] nf_tables: Change NFTA_NAT_ attributes to better semantic significance Tomasz Bursztyka
2012-11-15 9:15 ` [nf-next:nf_tables-experiments PATCH 2/4] nf_tables: Split IPv4 NAT into NAT expression and NAT IPv4 chain Tomasz Bursztyka
2012-11-15 12:26 ` Pablo Neira Ayuso
2012-11-15 12:38 ` Tomasz Bursztyka
2012-11-15 9:15 ` [nf-next:nf_tables-experiments PATCH 3/4] nf_tables: Add support for IPv6 NAT expression Tomasz Bursztyka
2012-11-15 12:29 ` Pablo Neira Ayuso
2012-11-15 12:44 ` Tomasz Bursztyka [this message]
2012-11-15 12:47 ` Pablo Neira Ayuso
2012-11-15 9:15 ` [nf-next:nf_tables-experiments PATCH 4/4] nf_tables: Add support for IPv6 NAT chain Tomasz Bursztyka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A4E3AB.3080703@linux.intel.com \
--to=tomasz.bursztyka@linux.intel.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).