From: Rick Jones <rick.jones2@hp.com>
To: Florent Fourcot <florent.fourcot@enst-bretagne.fr>
Cc: pablo@netfilter.org, yoshfuji@linux-ipv6.org,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] Fix comment for packets without data
Date: Thu, 13 Dec 2012 10:51:22 -0800 [thread overview]
Message-ID: <50CA23AA.1040501@hp.com> (raw)
In-Reply-To: <1355423248-12448-1-git-send-email-florent.fourcot@enst-bretagne.fr>
On 12/13/2012 10:27 AM, Florent Fourcot wrote:
> The double negation is probably a typo error
>
> Signed-off-by: Florent Fourcot <florent.fourcot@enst-bretagne.fr>
> ---
> net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c
> index 00ee17c..d9efe32 100644
> --- a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c
> +++ b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c
> @@ -81,7 +81,7 @@ static int ipv6_get_l4proto(const struct sk_buff *skb, unsigned int nhoff,
> }
> protoff = ipv6_skip_exthdr(skb, extoff, &nexthdr, &frag_off);
> /*
> - * (protoff == skb->len) mean that the packet doesn't have no data
> + * (protoff == skb->len) mean that the packet does not have any data
> * except of IPv6 & ext headers. but it's tracked anyway. - YK
> */
> if (protoff < 0 || (frag_off & htons(~0x7)) != 0) {
>
Might as well take it to completion and have it read "(protoff ==
skb->len) means the packet does not have any data" or "(protoff ==
skb->len) means the packet has no data" Not sure about that next line
with the except. Perhaps "(protoff == skb->len) means the packet has no
data, just IPv6 and extension headers, but it is tracked anyway."
rick jones
next prev parent reply other threads:[~2012-12-13 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 18:27 [PATCH] Fix comment for packets without data Florent Fourcot
2012-12-13 18:51 ` Rick Jones [this message]
2012-12-14 10:53 ` Florent Fourcot
2012-12-14 21:28 ` Rick Jones
2012-12-16 22:38 ` Pablo Neira Ayuso
2012-12-14 10:56 ` Florent Fourcot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CA23AA.1040501@hp.com \
--to=rick.jones2@hp.com \
--cc=florent.fourcot@enst-bretagne.fr \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).