From: Randy Dunlap <rdunlap@infradead.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfilter: fix missing dependencies for NETFILTER_XT_MATCH_CONNLABEL
Date: Sun, 03 Feb 2013 08:04:35 -0800 [thread overview]
Message-ID: <510E8A93.6050300@infradead.org> (raw)
In-Reply-To: <1359890647-25846-1-git-send-email-fw@strlen.de>
On 02/03/13 03:24, Florian Westphal wrote:
> It was possible to set
> NF_CONNTRACK=n
> NF_CONNTRACK_LABELS=y
>
> via NETFILTER_XT_MATCH_CONNLABEL=y:
>
> warning: (NETFILTER_XT_MATCH_CONNLABEL) selects NF_CONNTRACK_LABELS which has
> unmet direct dependencies (NET && INET && NETFILTER && NF_CONNTRACK)
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
> index eb2c8eb..d4dd702 100644
> --- a/net/netfilter/Kconfig
> +++ b/net/netfilter/Kconfig
> @@ -860,6 +860,7 @@ config NETFILTER_XT_MATCH_CONNBYTES
> config NETFILTER_XT_MATCH_CONNLABEL
> tristate '"connlabel" match support'
> select NF_CONNTRACK_LABELS
> + depends on NF_CONNTRACK
> depends on NETFILTER_ADVANCED
> ---help---
> This match allows you to test and assign userspace-defined labels names
>
--
~Randy
next prev parent reply other threads:[~2013-02-03 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130203005102.0d19fecc9e73f5af059045ef@canb.auug.org.au>
2013-02-03 2:20 ` linux-next: Tree for Feb 2 (netfilter) Randy Dunlap
2013-02-03 11:24 ` [PATCH] netfilter: fix missing dependencies for NETFILTER_XT_MATCH_CONNLABEL Florian Westphal
2013-02-03 16:04 ` Randy Dunlap [this message]
2013-02-05 3:00 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510E8A93.6050300@infradead.org \
--to=rdunlap@infradead.org \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).