From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH 1/2] netfilter: nf_tables: rework atomic transaction updates
Date: Tue, 02 Apr 2013 12:03:39 +0300 [thread overview]
Message-ID: <515A9EEB.2090701@linux.intel.com> (raw)
In-Reply-To: <1364502145-3701-2-git-send-email-pablo@netfilter.org>
Hi Pablo,
> * A new begin operation to explicitly enter the transaction mode,
> and remove the COMMIT flag per rule, as suggested by Tomasz.
Could you split your patch to 2?
- one which removes this flag and add *BEGIN* message stuff
- and a the later one which propose the rest
> +++ b/include/uapi/linux/netfilter/nf_tables.h
> @@ -37,6 +37,7 @@ enum nf_tables_msg_types {
> NFT_MSG_NEWSETELEM,
> NFT_MSG_GETSETELEM,
> NFT_MSG_DELSETELEM,
> + NFT_MSG_BEGIN,
> NFT_MSG_COMMIT,
> NFT_MSG_ABORT,
> NFT_MSG_MAX,
Still, I think it's awkward to propose a fully-explicit message name for
all but for the transaction ones.
NFT_MSG_BEGINTRANSACT or something like that, would be better.
Br,
Tomasz
next prev parent reply other threads:[~2013-04-02 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 20:22 [PATCH 0/2] nf_tables: atomic transactional updates (v2) pablo
2013-03-28 20:22 ` [PATCH 1/2] netfilter: nf_tables: rework atomic transaction updates pablo
2013-04-02 9:03 ` Tomasz Bursztyka [this message]
2013-03-28 20:22 ` [PATCH 2/2] netfilter: nf_tables: set NLM_F_DUMP_INTR if dump is invalid pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515A9EEB.2090701@linux.intel.com \
--to=tomasz.bursztyka@linux.intel.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).