From: Michael Zintakis <michael.zintakis@googlemail.com>
To: netfilter-devel@vger.kernel.org
Cc: pablo@netfilter.org
Subject: [PATCH nfnetlink_acct v2 1/2] nfnl_acct_new: add packet/byte values check
Date: Sun, 14 Apr 2013 10:53:39 +0100 [thread overview]
Message-ID: <516A7CA3.1020206@googlemail.com> (raw)
* check that in nfnetlink_acct.c::nfnl_acct_new both packet and byte
values are specified and return EINVAL if that is not the case
Signed-off-by: Michael Zintakis <michael.zintakis@googlemail.com>
---
net/netfilter/nfnetlink_acct.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/netfilter/nfnetlink_acct.c b/net/netfilter/nfnetlink_acct.c
index dc3fd5d..c8d1282 100644
--- a/net/netfilter/nfnetlink_acct.c
+++ b/net/netfilter/nfnetlink_acct.c
@@ -45,7 +45,9 @@ nfnl_acct_new(struct sock *nfnl, struct sk_buff *skb,
struct nf_acct *nfacct, *matching = NULL;
char *acct_name;
- if (!tb[NFACCT_NAME])
+ if (!tb[NFACCT_NAME] ||
+ (tb[NFACCT_BYTES] && !tb[NFACCT_PKTS]) ||
+ (!tb[NFACCT_BYTES] && tb[NFACCT_PKTS]))
return -EINVAL;
acct_name = nla_data(tb[NFACCT_NAME]);
reply other threads:[~2013-04-14 9:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516A7CA3.1020206@googlemail.com \
--to=michael.zintakis@googlemail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).