Re: v3.10-rc7 oops soon after boot

Re: v3.10-rc7 oops soon after boot

[Pablo Neira Ayuso]

On Mon, Jun 24, 2013 at 01:34:41PM +0200, Pablo Neira Ayuso wrote:
> On Mon, Jun 24, 2013 at 05:52:08PM +0800, Gao feng wrote:
> > On 06/24/2013 05:41 PM, George Spelvin wrote:
> > >> Please try the patch below,
> > >> I think this bug is introduced by me :(
> > >>
> > >> Thanks!
> > > 
> > > Well, you changed it, but it still crashes.
> > > 
> > > It's now at del_timer+0x9/0x58, with the code being:
> > 
> > This one should work.
> > 
> > Thanks for your quickly reply.
> 
> I managed to crash it using a group != 1 (default) and enabling
> batching:
> 
> iptables -I INPUT -j ULOG --ulog-nlgroup 2 --ulog-qthresh 50
> 
> It seems ulog->nlgroup[i] is always left unset.
> 
> I have mangled your patch, find it attached.

> From 79da8ea854c06ca9320decbb2f9d2e8d25b2f7e5 Mon Sep 17 00:00:00 2001
> From: Gao feng <gaofeng@cn.fujitsu.com>
> Date: Mon, 24 Jun 2013 17:04:02 +0800
> Subject: [PATCH] netfilter: ipt_ULOG: fix incorrect setting of ulog timer
> 
> The parameter of setup_timer should be &ulog->nlgroup[i].
> the incorrect parameter will cause kernel panic in
> ulog_timer.
> 
> Bug introducted in commit 355430671ad93546b34b4e91bdf720f3a704efa4
> "netfilter: ipt_ULOG: add net namespace support for ipt_ULOG"
> 
> ebt_ULOG doesn't have this problem.
> 
> Reported-by: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

I have applied the patch that I sent you.

Re: v3.10-rc7 oops soon after boot

[Borislav Petkov]

On Mon, Jun 24, 2013 at 05:10:31PM +0200, Pablo Neira Ayuso wrote:
> > I have mangled your patch, find it attached.
> 
> > From 79da8ea854c06ca9320decbb2f9d2e8d25b2f7e5 Mon Sep 17 00:00:00 2001
> > From: Gao feng <gaofeng@cn.fujitsu.com>
> > Date: Mon, 24 Jun 2013 17:04:02 +0800
> > Subject: [PATCH] netfilter: ipt_ULOG: fix incorrect setting of ulog timer
> > 
> > The parameter of setup_timer should be &ulog->nlgroup[i].
> > the incorrect parameter will cause kernel panic in
> > ulog_timer.
> > 
> > Bug introducted in commit 355430671ad93546b34b4e91bdf720f3a704efa4
> > "netfilter: ipt_ULOG: add net namespace support for ipt_ULOG"
> > 
> > ebt_ULOG doesn't have this problem.
> > 
> > Reported-by: Borislav Petkov <bp@alien8.de>

This should be:

Reported-by: George Spelvin <linux@horizon.com>

I only connected the dots...

:-)

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

Re: v3.10-rc7 oops soon after boot

[George Spelvin]

>> Reported-by: Borislav Petkov <bp@alien8.de>

> This should be:
>
> Reported-by: George Spelvin <linux@horizon.com>
>
> I only connected the dots...

Well, you did a whole lot more than me!  I just lobbed a "d'oh, it
crashes" into the seething ocean of lkml.  (Admittedly, I had reason
to act fast: we're very close to release.)

You figured out what subsystem was at fault and got the right people
involved.  Definitely a valuable contribution.

Me, personally, I don't give a flying f*** about such credit; I had
an itch and was trolling for someone to scratch it.

So feel free to take Reported-by (you are the one who reported it *to
someone who could fix it*), Triaged-by, or whatever.

Re: v3.10-rc7 oops soon after boot

[Borislav Petkov]

On Mon, Jun 24, 2013 at 06:17:08PM -0400, George Spelvin wrote:
> >> Reported-by: Borislav Petkov <bp@alien8.de>
> 
> > This should be:
> >
> > Reported-by: George Spelvin <linux@horizon.com>
> >
> > I only connected the dots...
> 
> Well, you did a whole lot more than me!  I just lobbed a "d'oh, it
> crashes" into the seething ocean of lkml.  (Admittedly, I had reason
> to act fast: we're very close to release.)
> 
> You figured out what subsystem was at fault and got the right people
> involved.  Definitely a valuable contribution.
> 
> Me, personally, I don't give a flying f*** about such credit; I had
> an itch and was trolling for someone to scratch it.
> 
> So feel free to take Reported-by (you are the one who reported it *to
> someone who could fix it*), Triaged-by, or whatever.

I was basically correcting how Reported-by is used - for the bug
reporter.

And yes, it is very important for us (even if you specifically don't
give a rat's rear end :-)) to credit the people - with their permission,
of course - who report bugs. Btw, I assume it is obvious why we need all
those good bug reports...

So I'm perfectly fine with you not giving flying f*ck about crediting as
long as you keep testing -rcs and reporting issues.

:-)

Thanks!

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

Re: v3.10-rc7 oops soon after boot

[Gao feng]

On 06/25/2013 06:17 AM, George Spelvin wrote:
>>> Reported-by: Borislav Petkov <bp@alien8.de>
> 
>> This should be:
>>
>> Reported-by: George Spelvin <linux@horizon.com>
>>
>> I only connected the dots...
> 
> Well, you did a whole lot more than me!  I just lobbed a "d'oh, it
> crashes" into the seething ocean of lkml.  (Admittedly, I had reason
> to act fast: we're very close to release.)
> 
> You figured out what subsystem was at fault and got the right people
> involved.  Definitely a valuable contribution.
> 
> Me, personally, I don't give a flying f*** about such credit; I had
> an itch and was trolling for someone to scratch it.
> 
> So feel free to take Reported-by (you are the one who reported it *to
> someone who could fix it*), Triaged-by, or whatever.

It's my mistake, the reported-by should be you.
of course we should thank Borislav, I didn't notice this bug report
mail until he forwarded it.

Thanks all you guys! Sorry for my mistake..

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>