From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: Giuseppe Longo <giuseppelng@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [xtables-arptables PATCH 3/4] nft: nft_xtables_config_load() called only in nft_init()
Date: Mon, 22 Jul 2013 18:41:12 +0300 [thread overview]
Message-ID: <51ED5298.1090501@linux.intel.com> (raw)
In-Reply-To: <20130716223053.13253.90159.stgit@nftables>
Hi Giuseppe,
I forgot to mention:
> h->tables = tables;
Provide tables as a parameter. Here you always take nft.c one. This
won't work for arptables.
>
> + /* If built-in chains don't exist for this table, create them */
> + if (nft_xtables_config_load(h, XTABLES_CONFIG_DEFAULT, 0) < 0) {
> + int i;
> +
Then do the for loop if only h->tables != NULL :
> + for (i=0; i<TABLES_MAX; i++)
> + if (h->tables[i].name != NULL)
> + nft_chain_builtin_init(h, h->tables[i].name, NULL, NF_ACCEPT);
next prev parent reply other threads:[~2013-07-22 15:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 22:30 [xtables-arptables PATCH 0/4] nft changes for xtables-arptables Giuseppe Longo
2013-07-16 22:30 ` [xtables-arptables PATCH 1/4] nft: add builtin_table pointer Giuseppe Longo
2013-07-16 22:30 ` [xtables-arptables PATCH 2/4] nft: search builtin tables via nft_handle tables pointer Giuseppe Longo
2013-07-16 22:30 ` [xtables-arptables PATCH 3/4] nft: nft_xtables_config_load() called only in nft_init() Giuseppe Longo
2013-07-22 15:35 ` Tomasz Bursztyka
2013-07-22 15:41 ` Tomasz Bursztyka [this message]
2013-07-16 22:31 ` [xtables-arptables PATCH 4/4] nft: make functions public Giuseppe Longo
2013-07-22 15:43 ` [xtables-arptables PATCH 0/4] nft changes for xtables-arptables Tomasz Bursztyka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ED5298.1090501@linux.intel.com \
--to=tomasz.bursztyka@linux.intel.com \
--cc=giuseppelng@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).