From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: Giuseppe Longo <giuseppelng@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables-nftables PATCH] nft: refactoring parse operations for more genericity
Date: Mon, 02 Sep 2013 12:26:08 +0300 [thread overview]
Message-ID: <522459B0.2080109@linux.intel.com> (raw)
In-Reply-To: <1377869753-9093-1-git-send-email-giuseppelng@gmail.com>
Hi Giuseppe,
> case NFT_GOTO:
> - ops = nft_family_ops_lookup(family);
> - ops->parse_immediate(cs);
> + nft_goto = true;
> + break;
You added a bogus "break" here: it should fall to NFT_JUMP to set the
chain as the jumpto.
That's the bug Pablo has found.
Tomasz
prev parent reply other threads:[~2013-09-02 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 13:35 [iptables-nftables PATCH] nft: refactoring parse operations for more genericity Giuseppe Longo
2013-08-30 22:31 ` Pablo Neira Ayuso
2013-09-02 9:26 ` Tomasz Bursztyka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522459B0.2080109@linux.intel.com \
--to=tomasz.bursztyka@linux.intel.com \
--cc=giuseppelng@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).