netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nftables-kernel PATCH] netfilter: nftables: Fix sparse endianness issue on nft_nat.c
Date: Mon, 28 Oct 2013 12:13:04 +0200	[thread overview]
Message-ID: <526E38B0.9000808@linux.intel.com> (raw)
In-Reply-To: <20131028094111.GA9725@macbook.localnet>

Hi Patrick,

> On Fri, Oct 18, 2013 at 12:00:53PM +0300, Tomasz Bursztyka wrote:
>> +			range.max_addr.ip =
>> +				be32_to_cpup((__be32 *)
>> +					data[priv->sreg_addr_max].data);
> That doesn't seem correct, we don't want to actually switch the byteorder of
> the data. I'd suggest to simply use (__force __be32).

Was sure I messed up with that. Thanks

Tomasz

      reply	other threads:[~2013-10-28 10:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-18  9:00 [nftables-kernel PATCH] netfilter: nftables: Fix sparse endianness issue on nft_nat.c Tomasz Bursztyka
2013-10-28  7:18 ` Tomasz Bursztyka
2013-10-28  9:41 ` Patrick McHardy
2013-10-28 10:13   ` Tomasz Bursztyka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=526E38B0.9000808@linux.intel.com \
    --to=tomasz.bursztyka@linux.intel.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).