netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Petrenas <zeracles@zeracles.net.ru>
To: netfilter-devel@vger.kernel.org
Subject: Kernel 4.1.0 broke the TARPIT & DELUGE targets in xtables-addons-2.6
Date: Tue, 23 Jun 2015 00:40:47 +0300	[thread overview]
Message-ID: <52756b9a-0699-405b-918c-73bcfafe97bb@zeracles.net.ru> (raw)

Hi!

Netfilter changes in the recent 4.1.0 kernel update included removal of the BRNF_BRIDGED flag:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=40451fd013878b005ccae767dfebc07dfecf85d9

Unfortunately, getting rid of BRNF_BRIDGED flag broke the xtables-addons-2.6 package, which now fails to build TARPIT & DELUGE targets with the following errors:

xtables-addons-2.6/extensions/xt_TARPIT.c:253:30: error: ‘BRNF_BRIDGED’ undeclared (first use in this function)
      nskb->nf_bridge->mask & BRNF_BRIDGED))
                              ^

xtables-addons-2.6/extensions/xt_TARPIT.c:282:2: error: too few arguments to function ‘NF_HOOK’
  NF_HOOK(NFPROTO_IPV4, NF_INET_LOCAL_OUT, nskb, NULL,
  ^

xtables-addons-2.6/extensions/xt_TARPIT.c:397:2: error: too few arguments to function ‘NF_HOOK’
  NF_HOOK(NFPROTO_IPV6, NF_INET_LOCAL_OUT, nskb, NULL,
  ^

scripts/Makefile.build:264: recipe for target 'xtables-addons-2.6/work/xtables-addons-2.6/extensions/xt_TARPIT.o' failed

My kernel hacking skills are non-existant (as well as my C skills), so I expectedly failed to come up with any patch that would replace BRNF_BRIDGED flag with nf_bridge->physoutdev in the following xt_TARPIT.c code:

#ifdef CONFIG_BRIDGE_NETFILTER
	if (hook != NF_INET_FORWARD || (nskb->nf_bridge != NULL &&
	    nskb->nf_bridge->mask & BRNF_BRIDGED))
#else

http://sourceforge.net/p/xtables-addons/xtables-addons/ci/master/tree/extensions/xt_TARPIT.c#l253

Can someone please show me how it can be fixed? (and hopefully update xtables package with the fix?)

Yours, Alexander Petrenas.

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in

             reply	other threads:[~2015-06-22 22:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-22 21:40 Alexander Petrenas [this message]
2015-06-23  9:39 ` Kernel 4.1.0 broke the TARPIT & DELUGE targets in xtables-addons-2.6 Florian Westphal
  -- strict thread matches above, loose matches on Subject: below --
2015-06-23 10:44 Alexander Petrenas
2015-06-23 11:17 ` Alexander Petrenas
2015-07-06  3:45   ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52756b9a-0699-405b-918c-73bcfafe97bb@zeracles.net.ru \
    --to=zeracles@zeracles.net.ru \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).