From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: Jan Engelhardt <jengelh@inai.de>,
Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 3/3] build: use automake and pkgconfig
Date: Wed, 20 Nov 2013 13:11:14 +0200 [thread overview]
Message-ID: <528C98D2.9080204@linux.intel.com> (raw)
In-Reply-To: <alpine.LSU.2.11.1311201008300.24243@nerf07.vanv.qr>
Hi Jan and Pablo,
I prefer this automake approach against current one, for instance:
> CC src/scanner.c
> <stdout>: In function ‘nft_lex’:
> <stdout>:1738:23: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
>
> I'll overlook -Werror for now…
This error could be better fixed with a Makefile.am as proposed in this
patchset, as found in
http://git.netfilter.org/conntrack-tools/tree/src/Makefile.am
Let's keep -Werror on all files but the crappy auto-generated bison/flex
ones.
It's better breaking and fixing the built files now rather than after
linux 3.13 release.
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-11-20 11:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-20 14:48 nftables: use automake & pkgconfig Jan Engelhardt
2013-10-20 14:48 ` [PATCH 1/3] build: remove unused checks Jan Engelhardt
2013-11-19 20:24 ` Pablo Neira Ayuso
2013-10-20 14:48 ` [PATCH 2/3] build: rename conflicting parser.h instances Jan Engelhardt
2013-11-19 20:25 ` Pablo Neira Ayuso
2013-11-20 9:06 ` Jan Engelhardt
2013-11-20 14:02 ` Pablo Neira Ayuso
2013-10-20 14:48 ` [PATCH 3/3] build: use automake and pkgconfig Jan Engelhardt
2013-11-19 20:28 ` Pablo Neira Ayuso
2013-11-20 10:54 ` Jan Engelhardt
2013-11-20 11:11 ` Tomasz Bursztyka [this message]
2013-11-20 13:54 ` Pablo Neira Ayuso
2013-11-20 14:06 ` Pablo Neira Ayuso
2013-11-20 14:14 ` Jan Engelhardt
2013-12-06 17:47 ` Jan Engelhardt
2013-11-17 20:39 ` nftables: use automake & pkgconfig Jan Engelhardt
-- strict thread matches above, loose matches on Subject: below --
2014-01-13 9:07 nftables: improve build system Jan Engelhardt
2014-01-13 9:07 ` [PATCH 3/3] build: use automake and pkgconfig Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528C98D2.9080204@linux.intel.com \
--to=tomasz.bursztyka@linux.intel.com \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).