From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH nf-next v3] netfilter: xtables: lightweight process control group matching Date: Sat, 28 Dec 2013 09:17:58 +0100 Message-ID: <52BE8936.6000001@redhat.com> References: <7d845623366ba0d435d5c82bf318455871929e90.1387815795.git.dborkman@redhat.com> <52BCF04B.3070908@huawei.com> <52BD34D1.1040708@redhat.com> <52BE2A79.6040504@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org, Tejun Heo , cgroups@vger.kernel.org To: Li Zefan Return-path: Received: from mx1.redhat.com ([209.132.183.28]:21089 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427Ab3L1ISP (ORCPT ); Sat, 28 Dec 2013 03:18:15 -0500 In-Reply-To: <52BE2A79.6040504@huawei.com> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On 12/28/2013 02:33 AM, Li Zefan wrote: > On 2013/12/27 16:05, Daniel Borkmann wrote: >> On 12/27/2013 04:13 AM, Li Zefan wrote: ... >>> I'd suggest splitting cls_cgroup code into 2 parts. The first part >>> is to manage cgroupfs and classid, and should be put into net/core/ >>> and add a new config like NET_CGROUP_CLASSID for it. The second part >>> is specific cls_cgroup code. >> >> Sure, if this is wished, I'd do this as a follow-up as it doesn't affect >> any of this code in netfilter here. > > We should clean up the code before introducing a new feature, not the > other way. Hehe, quite honestly, I think this is YOUR opinion of a "cleanup", which makes the code actually more complicated, and it's not strictly needed. If you are so desperate about this separation, fine, I will do this, but again, I don't think it's *strictly* required for this.