From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH nf-next v3] netfilter: xtables: lightweight process control group matching Date: Sat, 28 Dec 2013 19:04:58 +0100 Message-ID: <52BF12CA.80406@redhat.com> References: <7d845623366ba0d435d5c82bf318455871929e90.1387815795.git.dborkman@redhat.com> <52BCF04B.3070908@huawei.com> <52BD34D1.1040708@redhat.com> <52BE2A79.6040504@huawei.com> <52BE8936.6000001@redhat.com> <52BE8F50.4080005@redhat.com> <52BE97DC.5090807@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Cc: pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org, netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tejun Heo , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Li Zefan Return-path: In-Reply-To: <52BE97DC.5090807-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netfilter-devel.vger.kernel.org On 12/28/2013 10:20 AM, Li Zefan wrote: > On 2013/12/28 16:44, Daniel Borkmann wrote: >> On 12/28/2013 09:17 AM, Daniel Borkmann wrote: >>> On 12/28/2013 02:33 AM, Li Zefan wrote: >>>> On 2013/12/27 16:05, Daniel Borkmann wrote: >>>>> On 12/27/2013 04:13 AM, Li Zefan wrote: >>> ... >>>>>> I'd suggest splitting cls_cgroup code into 2 parts. The first part >>>>>> is to manage cgroupfs and classid, and should be put into net/core/ >>>>>> and add a new config like NET_CGROUP_CLASSID for it. The second part >>>>>> is specific cls_cgroup code. >>>>> >>>>> Sure, if this is wished, I'd do this as a follow-up as it doesn't affect >>>>> any of this code in netfilter here. >>>> >>>> We should clean up the code before introducing a new feature, not the >>>> other way. >>> >>> Hehe, quite honestly, I think this is YOUR opinion of a "cleanup", which >>> makes the code actually more complicated, and it's not strictly needed. >>> >>> If you are so desperate about this separation, fine, I will do this, but >>> again, I don't think it's *strictly* required for this. >> > > Currently we have: > > cls_cgroup > > With your patch, it's changed to: > > __ cls_cgroup > / > net_cgroup_classid - > \ __ netfilter_cgroup > > The code should be re-organized. > >> Thinking about this further a bit, with this separation into net/core/, you >> would need another Kconfig, where people choose between built-in or >> module (or none). > > Just disable module support for net_cgroup_classid. I never like the cgroup > feature that allows modular subsystems. It will be just about 100 lines of > code, so we gain little by making it modular. Futhermore with this change, > we can simplify include/linux/cls_cgroup.h > > Moreoever cls_cgroup is the only modular cgroup subsystem, so I may even remove > this feature from cgroup core after the change to cls_cgroup. Ok, will send a v4 with this change included, thanks. >> With built-in you would disallow people to load/unload the >> cgroup part during runtime. With the module, you would introduce a module >> dependency _for each_, even if you only want to use net_cls, which sort of >> is not what we want from a simple "cleanup".