From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 01/23] netfilter: nft_reject: fix compilation warning if NF_TABLES_IPV6 is disabled Date: Fri, 10 Jan 2014 23:33:22 +0300 Message-ID: <52D05912.1030606@cogentembedded.com> References: <1389314142-17969-1-git-send-email-pablo@netfilter.org> <1389314142-17969-2-git-send-email-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org To: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Return-path: Received: from mail-lb0-f174.google.com ([209.85.217.174]:57138 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755491AbaAJTdV (ORCPT ); Fri, 10 Jan 2014 14:33:21 -0500 Received: by mail-lb0-f174.google.com with SMTP id p9so1842348lbv.33 for ; Fri, 10 Jan 2014 11:33:18 -0800 (PST) In-Reply-To: <1389314142-17969-2-git-send-email-pablo@netfilter.org> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Hello. On 01/10/2014 03:35 AM, Pablo Neira Ayuso wrote: > net/netfilter/nft_reject.c: In function 'nft_reject_eval': > net/netfilter/nft_reject.c:37:14: warning: unused variable 'net' [-Wunused-variable] > Reported-by: kbuild test robot > Signed-off-by: Pablo Neira Ayuso > --- > net/netfilter/nft_reject.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > diff --git a/net/netfilter/nft_reject.c b/net/netfilter/nft_reject.c > index 0d690d4..7ae63cd 100644 > --- a/net/netfilter/nft_reject.c > +++ b/net/netfilter/nft_reject.c > @@ -34,8 +34,9 @@ static void nft_reject_eval(const struct nft_expr *expr, > const struct nft_pktinfo *pkt) > { > struct nft_reject *priv = nft_expr_priv(expr); > +#if IS_ENABLED(CONFIG_NF_TABLES_IPV6) > struct net *net = dev_net((pkt->in != NULL) ? pkt->in : pkt->out); > - Why remove empty line after the declaration block? > +#endif > switch (priv->type) { > case NFT_REJECT_ICMP_UNREACH: > if (priv->family == NFPROTO_IPV4) WBR, Sergei