[PATCH] libxtables: Print meaninful error message for an invalid MAC address string

[PATCH] libxtables: Print meaninful error message for an invalid MAC address string

[Mart Frauenlob]

[-- Attachment #1: Type: text/plain, Size: 104 bytes --]

Hello,

on usage of a malformed MAC address the error message was not descriptive.

Best regards,

Mart

[-- Attachment #2: libxtables-Print-meaningful-error-message-for-an-invalid.patch --]
[-- Type: text/plain, Size: 1016 bytes --]

>From e2b3628a66db473d230e83a6eb98389849e20de1 Mon Sep 17 00:00:00 2001
From: Mart Frauenlob <mart.frauenlob@chello.at>
Date: Sun, 2 Feb 2014 14:24:25 +0100
Subject: [PATCH] libxtables: Print meaningful error message for an invalid MAC address string

If an invalid MAC address is used on the commmand line, the error message
`ether' was not really describing the problem.

Signed-off-by: Mart Frauenlob <mart.frauenlob@chello.at>
---
 libxtables/xtoptions.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libxtables/xtoptions.c b/libxtables/xtoptions.c
index 78e9abd..9b4c5aa 100644
--- a/libxtables/xtoptions.c
+++ b/libxtables/xtoptions.c
@@ -802,7 +802,7 @@ static void xtopt_parse_ethermac(struct xt_option_call *cb)
 		       sizeof(cb->val.ethermac));
 	return;
  out:
-	xt_params->exit_err(PARAMETER_PROBLEM, "ether");
+	xt_params->exit_err(PARAMETER_PROBLEM, "Invalid MAC address specified.");
 }
 
 static void (*const xtopt_subparse[])(struct xt_option_call *) = {
-- 
1.7.2.5

Re: [PATCH] libxtables: Print meaninful error message for an invalid MAC address string

[Pablo Neira Ayuso]

On Sun, Feb 02, 2014 at 07:39:01PM +0100, Mart Frauenlob wrote:
> Hello,
> 
> on usage of a malformed MAC address the error message was not descriptive.

Applied, thanks.