From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Giuseppe Longo <giuseppelng@gmail.com>, netfilter-devel@vger.kernel.org
Subject: Re: [iptables 0/3] ebtables patchset
Date: Tue, 25 Mar 2014 13:37:06 +0200 [thread overview]
Message-ID: <53316A62.7020501@linux.intel.com> (raw)
In-Reply-To: <20140324150956.GA32546@localhost>
Hi Pablo,
> I think you
> have to do something similar to what Patrick did with nft_reject, by
> adding a specific flavour of nft_meta for the bridge family.
In case of nft_meta, it would mean quite much code change,
since most of the keys are valid also for NFPROTO_BRIDGE.
Or maybe I miss something. (I don't know if it's proper to register a
second expr
in the same nft_meta.c, dedicated to bridge)
Wouldn't it be easier if I just check ctx->afi->family to be NFPROTO_BRIDGE
in nft_meta_init if the given key is one of the bridge related?
At evaluation, I can still check pkt->ops->pf as well.
Does the logic sound relevant?
Tomasz
prev parent reply other threads:[~2014-03-25 11:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 19:33 [iptables 0/3] ebtables patchset Giuseppe Longo
2014-03-07 19:33 ` [iptables 1/3] xtables: bootstrap xtables-eb for nftables Giuseppe Longo
2014-03-07 19:33 ` [iptables 2/3] Operations for bridge family Giuseppe Longo
2014-03-07 19:33 ` [iptables 3/3] nft-shared: make compare_matches as public Giuseppe Longo
2014-03-07 20:28 ` Stephen Hemminger
2014-03-10 10:50 ` [iptables 0/3] ebtables patchset Tomasz Bursztyka
2014-03-24 15:09 ` Pablo Neira Ayuso
2014-03-24 15:26 ` Giuseppe Longo
2014-03-25 7:40 ` Tomasz Bursztyka
2014-03-25 11:37 ` Tomasz Bursztyka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53316A62.7020501@linux.intel.com \
--to=tomasz.bursztyka@linux.intel.com \
--cc=giuseppelng@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).