Re: linux-next: Tree for Apr 1 (netfilter)

Re: linux-next: Tree for Apr 1 (netfilter)

[Randy Dunlap]

On 04/01/2014 12:39 AM, Stephen Rothwell wrote:
> Hi all,
> 
> Please do not add material intended for v3.16 to your linux-next included
> branches until after v3.15-rc1 is released.
> 
> This tree still fails (more than usual) the powerpc allyesconfig build.
> 
> Changes since 20140331:
> 
> The ia64 tree lost its build failure.
> 
> The powerpc tree still had its build failure.
> 
> The v4l-dvb tree still had its build failure so I used the version from
> next-20140328.
> 
> The audit tree gained conflicts against Linus' and the net-next trees.
> 
> Non-merge commits (relative to Linus' tree): 10933
>  9135 files changed, 457444 insertions(+), 222441 deletions(-)
> 
> ----------------------------------------------------------------------------
> 
> I have created today's linux-next tree at
> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> (patches at http://www.kernel.org/pub/linux/kernel/next/ ).  If you
> are tracking the linux-next tree using git, you should not use "git pull"
> to do so as that will try to merge the new linux-next release with the
> old one.  You should use "git fetch" as mentioned in the FAQ on the wiki
> (see below).
> 
> You can see which trees have been included by looking in the Next/Trees
> file in the source.  There are also quilt-import.log and merge.log files
> in the Next directory.  Between each merge, the tree was built with
> a ppc64_defconfig for powerpc and an allmodconfig for x86_64 and a
> multi_v7_defconfig for arm. After the final fixups (if any), it is also
> built with powerpc allnoconfig (32 and 64 bit), ppc44x_defconfig and
> allyesconfig (this fails its final link) and i386, sparc, sparc64 and arm
> defconfig.
> 
> Below is a summary of the state of the merge.
> 
> I am currently merging 213 trees (counting Linus' and 28 trees of patches
> pending for Linus' tree).
> 
> Stats about the size of the tree over time can be seen at
> http://neuling.org/linux-next-size.html .
> 
> Status of my local build tests will be at
> http://kisskb.ellerman.id.au/linux-next .  If maintainers want to give
> advice about cross compilers/configs that work, we are always open to add
> more builds.
> 
> Thanks to Randy Dunlap for doing many randconfig builds.  And to Paul
> Gortmaker for triage and bug fixes.
> 
> There is a wiki covering stuff to do with linux-next at
> http://linux.f-seidel.de/linux-next/pmwiki/ .  Thanks to Frank Seidel.

 
on x86_64:

net/netfilter/xt_connlimit.c: In function 'connlimit_mt_check':
net/netfilter/xt_connlimit.c:380:18: warning: division by zero [-Wdiv-by-zero]

Maybe just use CONNLIMIT_LOCK_SLOTS instead of ARRAY_SIZE(...).


-- 
~Randy

Re: linux-next: Tree for Apr 1 (netfilter)

[David Miller]

From: Randy Dunlap <rdunlap@infradead.org>
Date: Tue, 01 Apr 2014 11:34:15 -0700

> on x86_64:
> 
> net/netfilter/xt_connlimit.c: In function 'connlimit_mt_check':
> net/netfilter/xt_connlimit.c:380:18: warning: division by zero [-Wdiv-by-zero]
> 
> Maybe just use CONNLIMIT_LOCK_SLOTS instead of ARRAY_SIZE(...).

I'd rather see that ARRAY_SIZE() be adjusted to work cleanly for zero
sized array elements.

Re: linux-next: Tree for Apr 1 (netfilter)

[Geert Uytterhoeven]

On Tue, Apr 1, 2014 at 9:22 PM, David Miller <davem@davemloft.net> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> Date: Tue, 01 Apr 2014 11:34:15 -0700
>
>> on x86_64:
>>
>> net/netfilter/xt_connlimit.c: In function 'connlimit_mt_check':
>> net/netfilter/xt_connlimit.c:380:18: warning: division by zero [-Wdiv-by-zero]
>>
>> Maybe just use CONNLIMIT_LOCK_SLOTS instead of ARRAY_SIZE(...).
>
> I'd rather see that ARRAY_SIZE() be adjusted to work cleanly for zero
> sized array elements.

Anyone with a suggestion?

Please note this is now in Linus' tree, possibly crashing people's boxes...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: linux-next: Tree for Apr 1 (netfilter)

[David Miller]

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Sun, 6 Apr 2014 15:50:04 +0200

> On Tue, Apr 1, 2014 at 9:22 PM, David Miller <davem@davemloft.net> wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>> Date: Tue, 01 Apr 2014 11:34:15 -0700
>>
>>> on x86_64:
>>>
>>> net/netfilter/xt_connlimit.c: In function 'connlimit_mt_check':
>>> net/netfilter/xt_connlimit.c:380:18: warning: division by zero [-Wdiv-by-zero]
>>>
>>> Maybe just use CONNLIMIT_LOCK_SLOTS instead of ARRAY_SIZE(...).
>>
>> I'd rather see that ARRAY_SIZE() be adjusted to work cleanly for zero
>> sized array elements.
> 
> Anyone with a suggestion?
> 
> Please note this is now in Linus' tree, possibly crashing people's boxes...

I took in the version of the fix I didn't like via Pablo for
now.

Re: linux-next: Tree for Apr 1 (netfilter)

[Geert Uytterhoeven]

Hi David,

On Sun, Apr 6, 2014 at 5:31 PM, David Miller <davem@davemloft.net> wrote:
>> On Tue, Apr 1, 2014 at 9:22 PM, David Miller <davem@davemloft.net> wrote:
>>> From: Randy Dunlap <rdunlap@infradead.org>
>>> Date: Tue, 01 Apr 2014 11:34:15 -0700
>>>> on x86_64:
>>>>
>>>> net/netfilter/xt_connlimit.c: In function 'connlimit_mt_check':
>>>> net/netfilter/xt_connlimit.c:380:18: warning: division by zero [-Wdiv-by-zero]
>>>>
>>>> Maybe just use CONNLIMIT_LOCK_SLOTS instead of ARRAY_SIZE(...).
>>>
>>> I'd rather see that ARRAY_SIZE() be adjusted to work cleanly for zero
>>> sized array elements.
>>
>> Anyone with a suggestion?
>>
>> Please note this is now in Linus' tree, possibly crashing people's boxes...
>
> I took in the version of the fix I didn't like via Pablo for
> now.

Thank you!

Fixing ARRAY_SIZE() can still be done later, if possible.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvald