From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zoltan Kiss Subject: Re: [PATCH v5] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors Date: Tue, 22 Apr 2014 19:02:39 +0100 Message-ID: <5356AEBF.5010505@citrix.com> References: <1395873465-22282-1-git-send-email-zoltan.kiss@citrix.com> <20140327.152956.1528740039185894234.davem@davemloft.net> <20140421112601.GC3200@hercules> <1398181118.3624.203.camel@deadeye.wl.decadent.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: netfilter-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mszeredi-AlSwsSmVLrQ@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, JBeulich-IBi9RG/b67k@public.gmane.org, therbert-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org, kadlec-K40Dz/62t/MgiyqX0sVFJYdd74u8MsAO@public.gmane.org, xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org, pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org, jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org, Paul.Durrant-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, fw-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org, David Miller To: Ben Hutchings , Luis Henriques Return-path: In-Reply-To: <1398181118.3624.203.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Sender: "dev" List-Id: netfilter-devel.vger.kernel.org On 22/04/14 16:38, Ben Hutchings wrote: > On Mon, 2014-04-21 at 12:26 +0100, Luis Henriques wrote: >> Hi David, >> >> On Thu, Mar 27, 2014 at 03:29:56PM -0400, David Miller wrote: >>> From: Zoltan Kiss >>> Date: Wed, 26 Mar 2014 22:37:45 +0000 >>> >>>> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't >>>> orphan them. Also, it doesn't handle errors, so this patch takes care of that >>>> as well, and modify the callers accordingly. skb_tx_error() is also added to >>>> the callers so they will signal the failed delivery towards the creator of the >>>> skb. >>>> >>>> Signed-off-by: Zoltan Kiss >>> >>> Fingers crossed :-) Applied, thanks Zoltan. >>> -- >>> To unsubscribe from this list: send the line "unsubscribe netdev" in >>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> Could you please queue this for stable as well? It has CVE-2014-2568 >> assigned to it and I believe it is applicable to some of the trees. > > It was applied to 3.13, but needs backporting to earlier versions. I > posted my attempt in > <1397429860.10849.86.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org> but it needs > testing/reviewing. This one is a different issue, although it is very similar. Zoli