netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bob Hockney <bhockney@ix.netcom.com>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH] nfnetlink_log mac address for 6in4 tunnels
Date: Wed, 5 Dec 2012 11:05:21 -0700 (GMT-07:00)	[thread overview]
Message-ID: <5368964.1354730721679.JavaMail.root@elwamui-rustique.atl.sa.earthlink.net> (raw)

For tunnelled ipv6in4 packets, the LOG target (xt_LOG.c) adjusts the start of the mac field to start at the ethernet header instead of the ipv4 header for the tunnel.  This patch conforms what is passed by the NFLOG target through nfnetlink to what the LOG target does.  Code borrowed from xt_LOG.c.

===
--- a/net/netfilter/nfnetlink_log.c        2012-11-28 17:11:02.285514325 -0700
+++ b/net/netfilter/nfnetlink_log.c 2012-11-28 17:10:38.551830948 -0700
@@ -382,6 +382,7 @@
        struct nfgenmsg *nfmsg;
        sk_buff_data_t old_tail = inst->skb->tail;
        struct sock *sk;
+       const unsigned char *hwhdrp;

        nlh = nlmsg_put(inst->skb, 0, 0,
                        NFNL_SUBSYS_ULOG << 8 | NFULNL_MSG_PACKET,
@@ -483,9 +484,16 @@
        if (indev && skb_mac_header_was_set(skb)) {
                if (nla_put_be16(inst->skb, NFULA_HWTYPE, htons(skb->dev->type)) ||
                    nla_put_be16(inst->skb, NFULA_HWLEN,
-                                htons(skb->dev->hard_header_len)) ||
-                   nla_put(inst->skb, NFULA_HWHEADER, skb->dev->hard_header_len,
-                           skb_mac_header(skb)))
+                                htons(skb->dev->hard_header_len)))
+                       goto nla_put_failure;
+
+               hwhdrp = skb_mac_header(skb);
+
+               if (skb->dev->type == ARPHRD_SIT)
+                       hwhdrp -= ETH_HLEN;
+
+               if (!(hwhdrp < skb->head) && nla_put(inst->skb, NFULA_HWHEADER,
+                           skb->dev->hard_header_len, hwhdrp))
                        goto nla_put_failure;
        }





             reply	other threads:[~2012-12-05 18:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-05 18:05 Bob Hockney [this message]
2012-12-11 11:33 ` [PATCH] nfnetlink_log mac address for 6in4 tunnels Pablo Neira Ayuso
  -- strict thread matches above, loose matches on Subject: below --
2012-12-13 17:37 Bob Hockney
2012-12-16 22:47 ` Pablo Neira Ayuso
2012-12-17  2:29   ` Bob Hockney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5368964.1354730721679.JavaMail.root@elwamui-rustique.atl.sa.earthlink.net \
    --to=bhockney@ix.netcom.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).