Re: [nftables PATCH v2] src: Replace TOS support for using DSCP support

["Álvaro Neira Ayuso" <alvaroneay@gmail.com>]

El 01/06/14 22:27, Patrick McHardy escribió:
> On Tue, May 27, 2014 at 04:18:20PM +0200, Alvaro Neira Ayuso wrote:
>> From: Álvaro Neira Ayuso <alvaroneay@gmail.com>
>>
>> Signed-off-by: Alvaro Neira Ayuso <alvaroneay@gmail.com>
>> ---
>> [changes in v2]
>> * Replace TOS support for using DSCP support
>>
>> Now, when we add a rule with DSCP, in the code generation step, nftables
>> compares 1 bytes but it should compare 6 bits. I think that the problem should
>> be in the code generation.
>
> I don't really see how this patch changes this. The kernel operates in units
> of bytes. For anything smaller nftables will have to generate appropriate
> bitwise operations. Please explain in more detail how this patch changes this.
>

Now, nothing. For that it's stopped. I'm working for doing a patch for 
operating in the kernel not only with units of bytes like you say. In a 
couple of days, I'm going to send it to the list.

Thanks for the review, Patrick

Álvaro
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html