From: "Jiří Prchal" <jiri.prchal@aksignal.cz>
To: Bryan Wu <cooloney@gmail.com>, Pablo Neira Ayuso <pablo@netfilter.org>
Cc: coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
kadlec@blackhole.kfki.hu, kaber@trash.net,
Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org
Subject: [PATCH] nf: xt_LED: fix too short led-always-blink
Date: Fri, 25 Jul 2014 09:21:01 +0200 [thread overview]
Message-ID: <53D2055D.3040200@aksignal.cz> (raw)
In-Reply-To: <CAK5ve-Kc_Kv_EnenJSNA9J60QoTtH-zEjPowrOPuUrsWkh3ACQ@mail.gmail.com>
If led-always-blink is set, then between switch led OFF and ON
is almost zero time. So blink is invisible. This use oneshot led trigger
with fixed time 50ms witch is enough to see blink.
Signed-off-by: Jiri <jiri.prchal@aksignal.cz>
---
net/netfilter/xt_LED.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/net/netfilter/xt_LED.c b/net/netfilter/xt_LED.c
index 993de2b..29b5af4 100644
--- a/net/netfilter/xt_LED.c
+++ b/net/netfilter/xt_LED.c
@@ -55,6 +55,7 @@ led_tg(struct sk_buff *skb, const struct xt_action_param *par)
{
const struct xt_led_info *ledinfo = par->targinfo;
struct xt_led_info_internal *ledinternal = ledinfo->internal_data;
+ unsigned long t=50; /* always blink 50ms */
/*
* If "always blink" is enabled, and there's still some time until the
@@ -62,9 +63,10 @@ led_tg(struct sk_buff *skb, const struct xt_action_param *par)
*/
if ((ledinfo->delay > 0) && ledinfo->always_blink &&
timer_pending(&ledinternal->timer))
- led_trigger_event(&ledinternal->netfilter_led_trigger, LED_OFF);
-
- led_trigger_event(&ledinternal->netfilter_led_trigger, LED_FULL);
+ led_trigger_blink_oneshot(&ledinternal->netfilter_led_trigger,
+ &t, &t, 1);
+ else
+ led_trigger_event(&ledinternal->netfilter_led_trigger, LED_FULL);
/* If there's a positive delay, start/update the timer */
if (ledinfo->delay > 0) {
--
1.9.1
next prev parent reply other threads:[~2014-07-25 7:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 9:17 [BUG] nf: xt_LED: led-always-blink invisible Jiří Prchal
2014-06-30 10:54 ` Pablo Neira Ayuso
2014-06-30 23:36 ` Bryan Wu
2014-07-25 7:21 ` Jiří Prchal [this message]
2014-07-25 12:22 ` [PATCH] nf: xt_LED: fix too short led-always-blink Pablo Neira Ayuso
2014-07-25 12:40 ` [PATCH v2] " Jiří Prchal
2014-07-25 12:59 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D2055D.3040200@aksignal.cz \
--to=jiri.prchal@aksignal.cz \
--cc=cooloney@gmail.com \
--cc=coreteam@netfilter.org \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-leds@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).