From: Daniel Borkmann <dborkman@redhat.com>
To: Alexey Perevalov <a.perevalov@samsung.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: none zero check of the classid in xt_cgroup
Date: Mon, 18 Aug 2014 15:52:29 +0200 [thread overview]
Message-ID: <53F2051D.7080607@redhat.com> (raw)
In-Reply-To: <53EEF618.6020103@samsung.com>
On 08/16/2014 08:11 AM, Alexey Perevalov wrote:
> Hello Daniel,
>
> I have a question regarding xt_cgroup, again )
>
> I'm interesting why did you add check for none zero id into cgroup_mt_check. With it, it's impossible
> to introduce some rules, like -m cgroup ! --cgroup 0. It could be useful for end user, for example, to block
> all processes which was under cgroups, but not whole traffic.
Yes, indeed, probably I was too focussed on [1] when in combination
with cls_cgroup (as they use the same cgroup) it's non-zero anyway;
but that doesn't make sense when in use as xt_cgroup stand-alone.
I've sent a patch, thanks.
[1] Documentation/cgroups/net_cls.txt
prev parent reply other threads:[~2014-08-18 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-16 6:11 none zero check of the classid in xt_cgroup Alexey Perevalov
2014-08-18 13:52 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F2051D.7080607@redhat.com \
--to=dborkman@redhat.com \
--cc=a.perevalov@samsung.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).