From: "Álvaro Neira Ayuso" <alvaroneay@gmail.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: [nft PATCH 4/4 v3] evaluate: fix a crash if we check the transport protocol is tcp
Date: Tue, 21 Oct 2014 14:28:46 +0200 [thread overview]
Message-ID: <5446517E.9070003@gmail.com> (raw)
In-Reply-To: <20141021081522.GB3628@salvia>
El 21/10/14 10:15, Pablo Neira Ayuso escribió:
> On Tue, Oct 21, 2014 at 01:29:40AM +0200, Alvaro Neira Ayuso wrote:
>> Example:
>>
>> nft add rule inet filter input meta l4proto udp reject with tcp reset
>>
>> If we try to check if the transport protocol is tcp, we use the network context.
>> If we don't have this network context, we have a crash.
>
> I have applied this with minor changes.
>
> Please, select the patch ordering carefully. This is a v3 coming as
> the 4th patch in a batch.
>
> Remember: Fixes always come in first place. Thanks.
>
Catched. Sorry.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-10-21 12:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 23:29 [nft PATCH 1/4] evaluate: refactor function to check the reject family in inet and bridge Alvaro Neira Ayuso
2014-10-20 23:29 ` [nft PATCH 2/4] evaluate: accept a reject reason with incorrect network context Alvaro Neira Ayuso
2014-10-20 23:29 ` [nft PATCH 3/4] evaluate: no check the network context in reject with tcp reset reason Alvaro Neira Ayuso
2014-10-21 7:55 ` Pablo Neira Ayuso
2014-10-21 12:32 ` Álvaro Neira Ayuso
2014-10-20 23:29 ` [nft PATCH 4/4 v3] evaluate: fix a crash if we check the transport protocol is tcp Alvaro Neira Ayuso
2014-10-21 8:15 ` Pablo Neira Ayuso
2014-10-21 12:28 ` Álvaro Neira Ayuso [this message]
2014-10-21 8:45 ` [nft PATCH 1/4] evaluate: refactor function to check the reject family in inet and bridge Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5446517E.9070003@gmail.com \
--to=alvaroneay@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).