From: Giorgio <giorgio.nicole@arcor.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 5/5] build: autotools conversion
Date: Fri, 07 Nov 2014 19:17:25 +0100 [thread overview]
Message-ID: <545D0CB5.90909@arcor.de> (raw)
In-Reply-To: <1415298349-985-6-git-send-email-pablo@netfilter.org>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
On 11/06/2014 07:25 PM, Pablo Neira Ayuso wrote:
> diff --git a/Make_global.am b/Make_global.am
> new file mode 100644
> index 0000000..8ad0eb0
> --- /dev/null
> +++ b/Make_global.am
> @@ -0,0 +1,10 @@
> +AM_CPPFLAGS = -I$(top_srcdir)/include
> +AM_CPPFLAGS += -DDEFAULT_INCLUDE_PATH="\"${sysconfdir}\"" -D__USE_GNU
> +
> +AM_CFLAGS = -Wall \
> + -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations \
> + -Wdeclaration-after-statement -Wsign-compare -Winit-self \
> + -Wformat-nonliteral -Wformat-security -Wmissing-format-attribute \
> + -Wcast-align -Wundef -Wbad-function-cast # -Wshadow \
> + -Waggregate-return -Wunused -Wwrite-strings \
> + ${LIBMNL_CFLAGS} ${LIBNFTNL_CFLAGS}
why do you need this new file? The #include in the main Makefile.am is
useless because you do not build anything there; the only right place to
have these definitions is under src/Makefile.am.
giorgio
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 246 bytes --]
next prev parent reply other threads:[~2014-11-07 18:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 18:25 [PATCH nft 0/5] autotools conversion Pablo Neira Ayuso
2014-11-06 18:25 ` [PATCH nft 1/5] build: use PKG_CHECK_MODULES to check for libmnl and libnftnl Pablo Neira Ayuso
2014-11-06 18:25 ` [PATCH nft 2/5] build: use AC_PROG_YACC and AM_PROG_LEX Pablo Neira Ayuso
2014-11-06 18:25 ` [PATCH nft 3/5] rename parser.y to parser_bison.y Pablo Neira Ayuso
2014-11-06 18:25 ` [PATCH nft 4/5] include: add cli.h Pablo Neira Ayuso
2014-11-06 18:25 ` [PATCH nft 5/5] build: autotools conversion Pablo Neira Ayuso
2014-11-06 20:29 ` Jan Engelhardt
2014-11-07 18:17 ` Giorgio [this message]
2014-11-09 20:26 ` [PATCH 1/1] autotools conversion fixups giorgio.nicole
2014-11-12 12:01 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545D0CB5.90909@arcor.de \
--to=giorgio.nicole@arcor.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).