netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Barth <cyrus@openwrt.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCHv2 0/4] support for mini-gmp / embedded friendliness
Date: Wed, 07 Jan 2015 13:29:02 +0100	[thread overview]
Message-ID: <54AD268E.8020702@openwrt.org> (raw)
In-Reply-To: <20150107122218.GA15735@salvia>


On 07.01.2015 13:22, Pablo Neira Ayuso wrote:
>
> I think you mentioned to me already but
>
>   configure: error: --with-mini-gmp MUST be used with --disable-debug
>
> any reason to enforce this?

The problem here is that pr_debug expands to gmp_printf which is not 
part of mini-gmp and the little replacement mpz_printf I added only 
allows for formatting a single mpz_t (which is enough for all the 
non-debug cases).

So there are 3 options basically.
1. Try to make gmp_printf standalone and port it from libgmp to mini-gmp.
     This looked like a huge and complicated effort and would likely 
blow up stuff considerably again.
2. Replace pr_debug's gmp_printf with regular printf and rewrite all the 
debug-calls to mpz_get_str()
     and free() which sounds painful.
3. Simply disabling debugging with mini-gmp.
     Easy way out without obstructing things too much otherwise.

  reply	other threads:[~2015-01-07 12:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06 22:40 [nft PATCHv2 0/4] support for mini-gmp / embedded friendliness Steven Barth
2015-01-06 22:40 ` [PATCH 1/4] parser: rename VERSION token to HDRVERSION Steven Barth
2015-01-06 22:40 ` [PATCH 2/4] datatype: use mpz_set_str instead of gmp_sscanf Steven Barth
2015-01-06 22:40 ` [PATCH 3/4] erec: use stdio vasprintf instead of gmp_vasprintf Steven Barth
2015-01-06 22:40 ` [PATCH 4/4] build: add --with-mini-gmp switch to use mini-gmp instead of libgmp Steven Barth
2015-01-07 12:22 ` [nft PATCHv2 0/4] support for mini-gmp / embedded friendliness Pablo Neira Ayuso
2015-01-07 12:29   ` Steven Barth [this message]
2015-01-07 12:52     ` Pablo Neira Ayuso
2015-01-07 13:04 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AD268E.8020702@openwrt.org \
    --to=cyrus@openwrt.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).