From: Richard Weinberger <richard@nod.at>
To: Joe Perches <joe@perches.com>, Steven Rostedt <rostedt@goodmis.org>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, sameo@linux.intel.com,
aloisio.almeida@openbossa.org, lauro.venancio@openbossa.org,
davem@davemloft.net, kadlec@blackhole.kfki.hu, kaber@trash.net,
pablo@netfilter.org
Subject: Re: [PATCH 5/5 v2] netfilter: Fix format string of nfnetlink_log proc file
Date: Fri, 10 Apr 2015 09:31:19 +0200 [thread overview]
Message-ID: <55277C47.4080201@nod.at> (raw)
In-Reply-To: <1428619177.5413.15.camel@perches.com>
Am 10.04.2015 um 00:39 schrieb Joe Perches:
> On Thu, 2015-04-09 at 23:57 +0200, Richard Weinberger wrote:
>> The printed values are all of type unsigned integer, therefore use
>> %u instead of %d. Otherwise an user can face negative values.
>
> Hey Richard.
>
> Just to clarify, this patch is for net and not for net-next
> as net-next has removed the seq_printf return uses.
>
> Are you going to submit an equivalent patch for net-next?
Hmm, you are right. It took me a few minutes to figure out what happened
because I did rebase my patches to net-next and fixed up 5/5 already.
Reading yesterday's bash history shows that I've used
git format-patch in a wrong way such that the comments from the old
branch were taken.
Thanks,
//richard
next prev parent reply other threads:[~2015-04-10 7:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 21:57 [PATCH 1/5 v2] netlink: Fix portid type in netlink_notify Richard Weinberger
2015-04-09 21:57 ` [PATCH 2/5 v2] nfc: Fix portid type in urelease_work Richard Weinberger
2015-04-09 21:57 ` [PATCH 3/5 v2] netfilter: Fix portid types Richard Weinberger
2015-04-09 21:57 ` [PATCH 4/5 v2] netfilter: Fix format string of nfnetlink_queue proc file Richard Weinberger
2015-04-09 21:57 ` [PATCH 5/5 v2] netfilter: Fix format string of nfnetlink_log " Richard Weinberger
2015-04-09 22:39 ` Joe Perches
2015-04-09 22:43 ` Steven Rostedt
2015-04-10 7:31 ` Richard Weinberger [this message]
2015-04-10 19:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55277C47.4080201@nod.at \
--to=richard@nod.at \
--cc=aloisio.almeida@openbossa.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=lauro.venancio@openbossa.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=rostedt@goodmis.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).