From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 2/4] netfilter: avoid build error if TPROXY/SOCKET=y && NF_DEFRAG_IPV6=m Date: Sat, 16 May 2015 22:07:27 +0300 Message-ID: <5557956F.9050508@cogentembedded.com> References: <1431802038-4502-1-git-send-email-pablo@netfilter.org> <1431802038-4502-3-git-send-email-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org To: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Return-path: Received: from mail-la0-f49.google.com ([209.85.215.49]:36063 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbbEPTHe (ORCPT ); Sat, 16 May 2015 15:07:34 -0400 Received: by lagv1 with SMTP id v1so166825701lag.3 for ; Sat, 16 May 2015 12:07:32 -0700 (PDT) In-Reply-To: <1431802038-4502-3-git-send-email-pablo@netfilter.org> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Hello. On 05/16/2015 09:47 PM, Pablo Neira Ayuso wrote: > From: Florian Westphal > With TPROXY=y but DEFRAG_IPV6=m we get build failure: > net/built-in.o: In function `tproxy_tg_init': > net/netfilter/xt_TPROXY.c:588: undefined reference to `nf_defrag_ipv6_enable' > If DEFRAG_IPV6 is modular, TPROXY must be too. > (or both must be builtin). > This enforces =m for both. > Reported-and-tested-by: Liu Hua > Signed-off-by: Florian Westphal > Signed-off-by: Pablo Neira Ayuso > --- > net/netfilter/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig > index f70e34a..a0f3e6a3 100644 > --- a/net/netfilter/Kconfig > +++ b/net/netfilter/Kconfig > @@ -863,6 +863,7 @@ config NETFILTER_XT_TARGET_TPROXY > depends on NETFILTER_XTABLES > depends on NETFILTER_ADVANCED > depends on (IPV6 || IPV6=n) > + depends on (IP6_NF_IPTABLES || IP6_NF_IPTABLES=n) > depends on IP_NF_MANGLE > select NF_DEFRAG_IPV4 > select NF_DEFRAG_IPV6 if IP6_NF_IPTABLES > @@ -1356,6 +1357,7 @@ config NETFILTER_XT_MATCH_SOCKET > depends on NETFILTER_ADVANCED > depends on !NF_CONNTRACK || NF_CONNTRACK > depends on (IPV6 || IPV6=n) > + depends on (IP6_NF_IPTABLES || IP6_NF_IPTABLES=n) Parens not needed here and in the previous hunk. WBR, Sergei