From: Eric Dumazet <eric.dumazet@gmail.com>
To: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2 nf 1/2] netfilter: nf_queue: fix possible use-after-free
Date: Mon, 28 Feb 2022 17:34:41 -0800 [thread overview]
Message-ID: <5576e8a3-1d0b-7715-bf45-150648601604@gmail.com> (raw)
In-Reply-To: <20220301002108.28338-2-fw@strlen.de>
On 2/28/22 16:21, Florian Westphal wrote:
> Eric Dumazet says:
> The sock_hold() side seems suspect, because there is no guarantee
> that sk_refcnt is not already 0.
>
> On failure, we cannot queue the packet and need to indicate an
> error. The packet will be dropped by the caller.
>
> v2: split skb prefetch hunk into separate change
>
> Fixes: 271b72c7fa82c ("udp: RCU handling for Unicast packets.")
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
SGTM, thanks !
Reviewed-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2022-03-01 1:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 0:21 [PATCH v2 nf 0/2] netfilter: nf_queue: be more careful with sk refcounts Florian Westphal
2022-03-01 0:21 ` [PATCH v2 nf 1/2] netfilter: nf_queue: fix possible use-after-free Florian Westphal
2022-03-01 1:34 ` Eric Dumazet [this message]
2022-03-01 0:21 ` [PATCH v2 nf 2/2] netfilter: nf_queue: handle socket prefetch Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5576e8a3-1d0b-7715-bf45-150648601604@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).