From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schultz Subject: Re: [PATCH] netfilter: per network namespace nfacct Date: Thu, 06 Aug 2015 12:56:06 +0200 Message-ID: <55C33D46.4080902@tpip.net> References: <1438789905-5716-1-git-send-email-aschultz@tpip.net> <20150806100713.GA18520@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org To: Pablo Neira Ayuso Return-path: Received: from mail.tpip.net ([92.43.49.48]:34168 "EHLO mail.tpip.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753059AbbHFK5v (ORCPT ); Thu, 6 Aug 2015 06:57:51 -0400 In-Reply-To: <20150806100713.GA18520@salvia> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On 08/06/2015 12:07 PM, Pablo Neira Ayuso wrote: > On Wed, Aug 05, 2015 at 05:51:45PM +0200, Andreas Schultz wrote: [..] >> +static void __net_exit nfnl_acct_net_exit(struct net *net) >> +{ >> + struct nf_acct *cur, *tmp; >> + >> + list_for_each_entry_safe(cur, tmp, &net->nfnl_acct_list, head) { >> + list_del_rcu(&cur->head); >> + >> + if (atomic_dec_and_test(&cur->refcnt)) >> + kfree_rcu(cur, rcu_head); >> + } >> +} > > You better use nfnl_acct_put() here, otherwise we leak a module > refcount. The module refcount is only taken in nfnl_acct_find_get. The initial insert into the list in nfnl_acct_new is not taking the module refcount. Releasing the module refcount here would IMHO release one recount to many. Or do I miss something? > > Other than that, this looks fine with me. Please send a v2. > > Thanks. Andreas