From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wilmer van der Gaast <wilmer@gaast.net>
Subject: Bug report: Segfault on nested sets with prefixes
Date: Sun, 06 Sep 2015 20:48:32 +0100
Message-ID: <55EC9890.1080205@gaast.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: netfilter-devel@vger.kernel.org
Return-path: <netfilter-devel-owner@vger.kernel.org>
Received: from roy.gaast.net ([80.101.33.21]:48402 "EHLO mail.gaast.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752700AbbIFTsg (ORCPT <rfc822;netfilter-devel@vger.kernel.org>);
	Sun, 6 Sep 2015 15:48:36 -0400
Received: from [IPv6:2001:8b0:8c7:5e0c:52e5:49ff:fe3b:6de] (ruby.dublin.gaast.net [IPv6:2001:8b0:8c7:5e0c:52e5:49ff:fe3b:6de])
	by mail.gaast.net (Postfix) with ESMTPSA id C88EF2C0EC
	for <netfilter-devel@vger.kernel.org>; Sun,  6 Sep 2015 21:48:32 +0200 (CEST)
Sender: netfilter-devel-owner@vger.kernel.org
List-ID: <netfilter-devel.vger.kernel.org>

Hello,

The following ruleset causes a segfault:

#! /usr/sbin/nft -f

flush table inet filter
				
define test1 = {
	1.1.1.0/24,
}

define test2 = {
	$test1,
	2.2.2.0/24,
}
								
table inet filter {
	chain input {
		type filter hook input priority 0;
		ip saddr $test2 counter;
	}
}

Either removing the /24s to make them addresses instead of prefixes, or 
including test1 instead of test2, avoids the crash.

Backtrace from valgrind:

==21601== Process terminating with default action of signal 11 (SIGSEGV)
==21601==  Access not within mapped region at address 0x1D
==21601==    at 0x54C2EB0: __gmpz_cmp (in 
/usr/lib/x86_64-linux-gnu/libgmp.so.10.2.0)
==21601==    by 0x416CFA: ei_lookup.isra.0 (segtree.c:121)
==21601==    by 0x417040: ei_insert (segtree.c:189)
==21601==    by 0x417040: set_to_segtree (segtree.c:339)
==21601==    by 0x417040: set_to_intervals (segtree.c:440)
==21601==    by 0x406652: do_add_set (rule.c:659)
==21601==    by 0x406978: do_add_table (rule.c:679)
==21601==    by 0x406978: do_command_add (rule.c:695)
==21601==    by 0x407AEB: do_command (rule.c:1024)
==21601==    by 0x4060A5: nft_netlink (main.c:194)
==21601==    by 0x4060A5: nft_run (main.c:235)
==21601==    by 0x405C17: main (main.c:360)

Is this the right place to report issues like this?


Kind regards,

Wilmer van der Gaast.

-- 
+-------- .''`.     - -- ---+  +        - -- --- ---- ----- ------+
| wilmer : :'  :  gaast.net |  | OSS Programmer   www.bitlbee.org |
| lintux `. `~'  debian.org |  | Full-time geek  wilmer.gaast.net |
+--- -- -  ` ---------------+  +------ ----- ---- --- -- -        +