From: Jens Axboe <axboe@kernel.dk>
To: Geliang Tang <geliangtang@163.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Jan Kara <jack@suse.cz>, Josef Bacik <jbacik@fb.com>,
Josh Triplett <josh@joshtriplett.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Seth Jennings <sjenning@redhat.com>,
Jiri Kosina <jikos@kernel.org>, Vojtech Pavlik <vojtech@suse.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
live-patching@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] list: introduce list_is_first()
Date: Thu, 10 Dec 2015 08:10:34 -0700 [thread overview]
Message-ID: <566995EA.80509@kernel.dk> (raw)
In-Reply-To: <305feb971ae11e192f35f25d66bb7b2e28e06c39.1449755818.git.geliangtang@163.com>
On 12/10/2015 07:17 AM, Geliang Tang wrote:
> We already have list_is_last(), it makes sense to also add
> list_is_first() for consistency. This list utility function
> to check for first element in a list.
Honestly, I think we already have way too many of these kind of helpers.
IMHO they don't really help, they hurt readability. You should know how
the list works anyway, and if you do, then it's a no-brainer what's
first and last. If you don't, then you are bound to screw up in other ways.
Just my 2 cents.
--
Jens Axboe
next prev parent reply other threads:[~2015-12-10 15:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 14:17 [PATCH 1/4] list: introduce list_is_first() Geliang Tang
2015-12-10 14:17 ` [PATCH 2/4] livepatch: use list_is_first() Geliang Tang
2015-12-10 14:17 ` [PATCH 3/4] netfilter: ipset: " Geliang Tang
2015-12-10 14:20 ` [PATCH 4/4] elevator: use list_is_{first,last} Geliang Tang
2015-12-10 15:10 ` Jens Axboe [this message]
2015-12-10 15:23 ` [PATCH 1/4] list: introduce list_is_first() Josh Poimboeuf
2015-12-10 15:35 ` Jens Axboe
2015-12-10 16:47 ` Jiri Kosina
2015-12-10 15:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566995EA.80509@kernel.dk \
--to=axboe@kernel.dk \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=geliangtang@163.com \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=jikos@kernel.org \
--cc=josh@joshtriplett.org \
--cc=jpoimboe@redhat.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).