From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Zhouyi Zhou <zhouzhouyi@gmail.com>,
eric.dumazet@gmail.com, pablo@netfilter.org, kaber@trash.net,
kadlec@blackhole.kfki.hu, davem@davemloft.net,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.or
Cc: Zhouyi Zhou <yizhouzhou@ict.ac.cn>
Subject: Re: [PATCH V2] netfilter: h323: avoid potential attack
Date: Thu, 28 Jan 2016 17:11:18 +0300 [thread overview]
Message-ID: <56AA2186.1090208@cogentembedded.com> (raw)
In-Reply-To: <1453971597-4811-1-git-send-email-zhouzhouyi@gmail.com>
Hello.
On 1/28/2016 11:59 AM, Zhouyi Zhou wrote:
> Thanks Eric for your review and advice.
>
> I think hackers chould build a malicious h323 packet to overflow
> the pointer p which will panic during the memcpy(addr, p, len)
>
> For example, he may fabricate a very large taddr->ipAddress.ip;
>
> Signed-off-by: Zhouyi Zhou <yizhouzhou@ict.ac.cn>
> ---
> net/netfilter/nf_conntrack_h323_main.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/net/netfilter/nf_conntrack_h323_main.c b/net/netfilter/nf_conntrack_h323_main.c
> index 9511af0..ccd08c5 100644
> --- a/net/netfilter/nf_conntrack_h323_main.c
> +++ b/net/netfilter/nf_conntrack_h323_main.c
> @@ -110,6 +110,7 @@ int (*nat_q931_hook) (struct sk_buff *skb,
>
> static DEFINE_SPINLOCK(nf_h323_lock);
> static char *h323_buffer;
> +#define CHECK_BOUND(p, n) ((void *)p + n - (void *)h323_buffer > 65536)
You have to enclose the macro parameters in parens when used in expression.
MBR, Sergei
next prev parent reply other threads:[~2016-01-28 14:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 8:59 [PATCH V2] netfilter: h323: avoid potential attack Zhouyi Zhou
2016-01-28 12:57 ` Eric Dumazet
2016-01-28 13:14 ` Zhouyi Zhou
2016-01-28 14:00 ` Eric Dumazet
2016-01-28 14:07 ` Eric Dumazet
2016-01-28 14:15 ` One Thousand Gnomes
2016-01-28 14:11 ` Sergei Shtylyov [this message]
2016-01-28 14:29 ` Florian Westphal
2016-01-28 15:13 ` Zhouyi Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA2186.1090208@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.or \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=yizhouzhou@ict.ac.cn \
--cc=zhouzhouyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).