netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "stéphane bryant" <stephane.ml.bryant@gmail.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next v3 2/3] netfilter: bridge: pass L2 header and VLAN as netlink attributes in queues to userspace
Date: Sat, 5 Mar 2016 19:32:18 +0100	[thread overview]
Message-ID: <56DB2632.1020308@gmail.com> (raw)
In-Reply-To: <20160229124032.GA15467@salvia>


> 
> Stephane, I'm very looking forward to having this update pushed
> mainstream.
> 
> However, this I think it would be good if you can translate this to
> use nested attributes.
> 
> See nla_nest_start() and nla_nest_end(). Then, add a new vlan
> attributes for this:
> 
>         enum nfqnl_vlan_attr {
>                 NFQA_VLAN_UNSPEC,
>                 NFQA_VLAN_PROTO,
>                 NFQA_VLAN_TCI,
>                 __NFQA_VLAN_MAX,
>         };
>         #define NFQA_VLAN_MAX   (__NFQA_VLAN_MAX + 1)
> 
> Using structure to encapsulate netlink data is highly discouraged. I
> know we're doing this already in old attribute but that we cannot
> change since it's part of the ABI. But I would like that we start
> doing this the right way for new attributes.

Apologies for the delay -- i missed the email. I will try to get this
done within 3 weeks.



  reply	other threads:[~2016-03-05 18:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-20  9:07 [PATCH nf-next v3 1/3] netfilter: bridge: add nf_afinfo to enable queuing to userspace Stephane Bryant
2016-02-20  9:07 ` [PATCH nf-next v3 2/3] netfilter: bridge: pass L2 header and VLAN as netlink attributes in queues " Stephane Bryant
2016-02-29 12:40   ` Pablo Neira Ayuso
2016-03-05 18:32     ` stéphane bryant [this message]
2016-02-20  9:07 ` [PATCH nf-next v3 3/3] netfilter: bridge: nf queue verdict to use NFQA_VLAN and NFQA_L2HDR Stephane Bryant
2016-02-20  9:56   ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56DB2632.1020308@gmail.com \
    --to=stephane.ml.bryant@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).