* [RFC] nft: Remove memory-leak
@ 2016-03-13 12:08 Piyush Pangtey
2016-03-13 20:22 ` Florian Westphal
0 siblings, 1 reply; 3+ messages in thread
From: Piyush Pangtey @ 2016-03-13 12:08 UTC (permalink / raw)
To: netfilter-devel; +Cc: pablo
Memory leak due to the absence of matching free :
==4797== 189 bytes in 27 blocks are definitely lost in loss record 22 of 51
==4797== at 0x4C2AB80: malloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==4797== by 0x57A3839: strdup (strdup.c:42)
==4797== by 0x41C00D: xstrdup (utils.c:64)
==4797== by 0x411E4B: netlink_delinearize_chain.isra.3 (netlink.c:717)
==4797== by 0x411F20: list_chain_cb (netlink.c:748)
==4797== by 0x504A943: nft_chain_list_foreach (chain.c:1015)
==4797== by 0x41455E: netlink_list_chains (netlink.c:771)
==4797== by 0x4078EF: cache_init_objects (rule.c:90)
==4797== by 0x4078EF: cache_init (rule.c:130)
==4797== by 0x4078EF: cache_update (rule.c:147)
==4797== by 0x40FB09: cmd_evaluate (evaluate.c:2475)
==4797== by 0x4296BC: nft_parse (parser_bison.y:655)
==4797== by 0x4064CC: nft_run (main.c:231)
==4797== by 0x42CE57: cli_complete (cli.c:124)
==4797==
==4797== LEAK SUMMARY:
==4797== definitely lost: 189 bytes in 27 blocks
==4797== indirectly lost: 0 bytes in 0 blocks
==4797== possibly lost: 0 bytes in 0 blocks
==4797== still reachable: 112,010 bytes in 278 blocks
==4797== suppressed: 0 bytes in 0 blocks
After removing xstrdup from src/netlink.c:717 and src/netlink.c:722:
==4545==
==4545== HEAP SUMMARY:
==4545== in use at exit: 111,856 bytes in 269 blocks
==4545== total heap usage: 796 allocs, 527 frees, 754,306 bytes allocated
==4545==
==4545== LEAK SUMMARY:
==4545== definitely lost: 0 bytes in 0 blocks
==4545== indirectly lost: 0 bytes in 0 blocks
==4545== possibly lost: 0 bytes in 0 blocks
==4545== still reachable: 111,856 bytes in 269 blocks
==4545== suppressed: 0 bytes in 0 blocks
Signed-off-by: Piyush Pangtey <gokuvsvegita@gmail.com>
---
src/netlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/netlink.c b/src/netlink.c
index ba0c20a..2917288 100644
--- a/src/netlink.c
+++ b/src/netlink.c
@@ -714,12 +714,12 @@ static struct chain *netlink_delinearize_chain(struct netlink_ctx *ctx,
chain->priority =
nftnl_chain_get_s32(nlc, NFTNL_CHAIN_PRIO);
chain->type =
- xstrdup(nftnl_chain_get_str(nlc, NFTNL_CHAIN_TYPE));
+ nftnl_chain_get_str(nlc, NFTNL_CHAIN_TYPE);
chain->policy =
nftnl_chain_get_u32(nlc, NFTNL_CHAIN_POLICY);
if (nftnl_chain_is_set(nlc, NFTNL_CHAIN_DEV)) {
chain->dev =
- xstrdup(nftnl_chain_get_str(nlc, NFTNL_CHAIN_DEV));
+ nftnl_chain_get_str(nlc, NFTNL_CHAIN_DEV);
}
chain->flags |= CHAIN_F_BASECHAIN;
}
--
1.9.1
--
With regards,
Piyush Pangtey <gokuvsvegita@gmail.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RFC] nft: Remove memory-leak
2016-03-13 12:08 [RFC] nft: Remove memory-leak Piyush Pangtey
@ 2016-03-13 20:22 ` Florian Westphal
2016-03-14 8:48 ` Piyush Pangtey
0 siblings, 1 reply; 3+ messages in thread
From: Florian Westphal @ 2016-03-13 20:22 UTC (permalink / raw)
To: Piyush Pangtey; +Cc: netfilter-devel, pablo
Piyush Pangtey <gokuvsvegita@gmail.com> wrote:
> Memory leak due to the absence of matching free :
> ==4797== 189 bytes in 27 blocks are definitely lost in loss record 22 of 51
> ==4797== at 0x4C2AB80: malloc (in
> /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==4797== by 0x57A3839: strdup (strdup.c:42)
> ==4797== by 0x41C00D: xstrdup (utils.c:64)
> ==4797== by 0x411E4B: netlink_delinearize_chain.isra.3 (netlink.c:717)
> ==4797== by 0x411F20: list_chain_cb (netlink.c:748)
> ==4797== by 0x504A943: nft_chain_list_foreach (chain.c:1015)
> ==4797== by 0x41455E: netlink_list_chains (netlink.c:771)
> ==4797== by 0x4078EF: cache_init_objects (rule.c:90)
> ==4797== by 0x4078EF: cache_init (rule.c:130)
> ==4797== by 0x4078EF: cache_update (rule.c:147)
> ==4797== by 0x40FB09: cmd_evaluate (evaluate.c:2475)
> ==4797== by 0x4296BC: nft_parse (parser_bison.y:655)
> ==4797== by 0x4064CC: nft_run (main.c:231)
> ==4797== by 0x42CE57: cli_complete (cli.c:124)
..
> --- a/src/netlink.c
> +++ b/src/netlink.c
> @@ -714,12 +714,12 @@ static struct chain *netlink_delinearize_chain(struct netlink_ctx *ctx,
> chain->priority =
> nftnl_chain_get_s32(nlc, NFTNL_CHAIN_PRIO);
> chain->type =
> - xstrdup(nftnl_chain_get_str(nlc, NFTNL_CHAIN_TYPE));
> + nftnl_chain_get_str(nlc, NFTNL_CHAIN_TYPE);
This looks wrong, nlc lifetime is not tied to chain object.
Seems chain_free() needs xfree calls for type and ->dev ?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] nft: Remove memory-leak
2016-03-13 20:22 ` Florian Westphal
@ 2016-03-14 8:48 ` Piyush Pangtey
0 siblings, 0 replies; 3+ messages in thread
From: Piyush Pangtey @ 2016-03-14 8:48 UTC (permalink / raw)
To: Florian Westphal; +Cc: netfilter-devel
On Monday 14 March 2016 01:52 AM, Florian Westphal wrote:
> Piyush Pangtey <gokuvsvegita@gmail.com> wrote:
>> Memory leak due to the absence of matching free :
>> ==4797== 189 bytes in 27 blocks are definitely lost in loss record 22 of 51
>> ==4797== at 0x4C2AB80: malloc (in
>> /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
>> ==4797== by 0x57A3839: strdup (strdup.c:42)
>> ==4797== by 0x41C00D: xstrdup (utils.c:64)
>> ==4797== by 0x411E4B: netlink_delinearize_chain.isra.3 (netlink.c:717)
>> ==4797== by 0x411F20: list_chain_cb (netlink.c:748)
>> ==4797== by 0x504A943: nft_chain_list_foreach (chain.c:1015)
>> ==4797== by 0x41455E: netlink_list_chains (netlink.c:771)
>> ==4797== by 0x4078EF: cache_init_objects (rule.c:90)
>> ==4797== by 0x4078EF: cache_init (rule.c:130)
>> ==4797== by 0x4078EF: cache_update (rule.c:147)
>> ==4797== by 0x40FB09: cmd_evaluate (evaluate.c:2475)
>> ==4797== by 0x4296BC: nft_parse (parser_bison.y:655)
>> ==4797== by 0x4064CC: nft_run (main.c:231)
>> ==4797== by 0x42CE57: cli_complete (cli.c:124)
> ..
>> --- a/src/netlink.c
>> +++ b/src/netlink.c
>> @@ -714,12 +714,12 @@ static struct chain *netlink_delinearize_chain(struct netlink_ctx *ctx,
>> chain->priority =
>> nftnl_chain_get_s32(nlc, NFTNL_CHAIN_PRIO);
>> chain->type =
>> - xstrdup(nftnl_chain_get_str(nlc, NFTNL_CHAIN_TYPE));
>> + nftnl_chain_get_str(nlc, NFTNL_CHAIN_TYPE);
>
> This looks wrong, nlc lifetime is not tied to chain object.
> Seems chain_free() needs xfree calls for type and ->dev ?
>
Yes.Thanks for commenting.
I tried this as a workaround, because I was not sure about nlc :).
I sent a patch for adding matching free calls to chain_free().
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-14 8:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-13 12:08 [RFC] nft: Remove memory-leak Piyush Pangtey
2016-03-13 20:22 ` Florian Westphal
2016-03-14 8:48 ` Piyush Pangtey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).