From: Balbir Singh <bsingharora@gmail.com>
To: nicolas.dichtel@6wind.com, netdev@vger.kernel.org
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
linux-wpan@vger.kernel.org, aar@pengutronix.de,
pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu,
pshelar@nicira.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, netfilter-devel@vger.kernel.org,
dev@openvswitch.org, steffen.klassert@secunet.com,
herbert@gondor.apana.org.au
Subject: Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit
Date: Wed, 27 Apr 2016 22:29:22 +1000 [thread overview]
Message-ID: <5720B0A2.1030405@gmail.com> (raw)
In-Reply-To: <57206A47.2010906@6wind.com>
On 27/04/16 17:29, Nicolas Dichtel wrote:
> Le 27/04/2016 03:14, Balbir Singh a écrit :
>>
>>
>> On 23/04/16 01:31, Nicolas Dichtel wrote:
>>> Goal of this patch is to use the new libnl API to align netlink attribute
>>> when needed.
>>> The layout of the netlink message will be a bit different after the patch,
>>> because the padattr (TASKSTATS_TYPE_STATS) will be inside the nested
>>> attribute instead of before it.
>>>
>>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>>
>> The layout will change/break user space -- I've not tested the patch though..
> Sigh.
>
> I quote David:
> "All userspace components using netlink should always ignore attributes
> they do not recognize in dumps.
>
> This is one of the most basic principles of netlink"
>
> Do you have some pointers so I can made some tests?
>
Please try
https://www.kernel.org/doc/Documentation/accounting/getdelays.c
iotop uses it as well. My concern is ABI breakage of user space.
Balbir Singh
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-04-27 12:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 15:31 [PATCH net-next 0/9] netlink: align attributes when needed (patchset #1) Nicolas Dichtel
2016-04-22 15:31 ` [PATCH net-next 1/9] libnl: fix help of _64bit functions Nicolas Dichtel
2016-04-22 15:31 ` [PATCH net-next 2/9] libnl: nla_put_le64(): align on a 64-bit area Nicolas Dichtel
[not found] ` <1461339084-3849-3-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-04-22 16:51 ` Eric Dumazet
2016-04-23 17:05 ` Alexander Aring
2016-04-23 17:28 ` Alexander Aring
[not found] ` <9d534571-916d-b368-a398-7f03a1f512ec-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-04-25 7:41 ` Nicolas Dichtel
2016-04-22 15:31 ` [PATCH net-next 3/9] libnl: nla_put_be64(): " Nicolas Dichtel
2016-04-22 15:31 ` [PATCH net-next 4/9] libnl: nla_put_net64(): " Nicolas Dichtel
[not found] ` <1461339084-3849-1-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-04-22 15:31 ` [PATCH net-next 5/9] libnl: nla_put_s64(): " Nicolas Dichtel
2016-04-22 15:31 ` [PATCH net-next 6/9] libnl: nla_put_msecs(): " Nicolas Dichtel
2016-04-24 0:13 ` [PATCH net-next 0/9] netlink: align attributes when needed (patchset #1) David Miller
2016-04-22 15:31 ` [PATCH net-next 7/9] libnl: add nla_put_u64_64bit() helper Nicolas Dichtel
2016-04-22 15:31 ` [PATCH net-next 8/9] xfrm: align nlattr properly when needed Nicolas Dichtel
2016-04-22 15:31 ` [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit Nicolas Dichtel
[not found] ` <1461339084-3849-10-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-04-27 1:14 ` Balbir Singh
[not found] ` <57201287.80002-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-04-27 7:29 ` Nicolas Dichtel
2016-04-27 12:29 ` Balbir Singh [this message]
[not found] ` <5720B0A2.1030405-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-04-27 15:46 ` Nicolas Dichtel
2016-04-27 15:47 ` [PATCH net-next] taskstats: fix nl parsing in accounting/getdelays.c Nicolas Dichtel
[not found] ` <1461772077-3216-1-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-04-27 15:49 ` Nicolas Dichtel
[not found] ` <5720DFA1.3080503-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-04-27 15:53 ` [PATCH net-next v2] " Nicolas Dichtel
[not found] ` <1461772388-3763-1-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2016-04-27 16:56 ` David Miller
2016-04-27 16:41 ` [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5720B0A2.1030405@gmail.com \
--to=bsingharora@gmail.com \
--cc=aar@pengutronix.de \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pablo@netfilter.org \
--cc=pshelar@nicira.com \
--cc=steffen.klassert@secunet.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).