From: Thomas Haller <thaller@redhat.com>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org,
"Maciej Żenczykowski" <zenczykowski@gmail.com>
Subject: Re: [PATCH v2 nft] parser: tcpopt: fix tcp option parsing with NUM + length field
Date: Wed, 06 Dec 2023 12:50:00 +0100 [thread overview]
Message-ID: <5aece71107a2716d9e6742cbc4e159c8c65a5ba0.camel@redhat.com> (raw)
In-Reply-To: <20231206113836.GE8352@breakpoint.cc>
On Wed, 2023-12-06 at 12:38 +0100, Florian Westphal wrote:
> Thomas Haller <thaller@redhat.com> wrote:
> > Hi Florian,
> >
> > On Tue, 2023-12-05 at 12:56 +0100, Florian Westphal wrote:
> > > .../packetpath/dumps/tcp_options.nft | 14 +++++++
> >
> > is there a reason not to also generate a .json-nft file?
>
> Yes, I am not adding more one-line monsters.
>
> I'll add one once there is a solution in place that has human
> readable
> json dumps that don't fail validation because of identical but
> differently formatted output.
>
What about the "[PATCH nft 0/2] pretty print .json-nft files" patches?
Thomas
next prev parent reply other threads:[~2023-12-06 11:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 11:56 [PATCH v2 nft] parser: tcpopt: fix tcp option parsing with NUM + length field Florian Westphal
2023-12-05 12:07 ` Pablo Neira Ayuso
2023-12-05 12:20 ` Florian Westphal
2023-12-05 12:50 ` Pablo Neira Ayuso
2023-12-05 13:14 ` Florian Westphal
2023-12-05 14:10 ` Pablo Neira Ayuso
2023-12-06 7:58 ` Thomas Haller
2023-12-06 11:38 ` Florian Westphal
2023-12-06 11:50 ` Thomas Haller [this message]
2023-12-06 11:59 ` Florian Westphal
2023-12-06 12:04 ` Florian Westphal
2023-12-06 12:09 ` Thomas Haller
2023-12-06 12:16 ` Florian Westphal
2023-12-06 13:22 ` Thomas Haller
2023-12-06 13:24 ` Florian Westphal
2023-12-06 14:56 ` Thomas Haller
2023-12-06 14:19 ` Phil Sutter
2023-12-06 15:12 ` Thomas Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aece71107a2716d9e6742cbc4e159c8c65a5ba0.camel@redhat.com \
--to=thaller@redhat.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).