From: wzt wzt <wzt.wzt@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] Netfilter: Fix integer overflow in net/ipv6/netfilter/ip6_tables.c
Date: Tue, 23 Mar 2010 09:34:09 +0800 [thread overview]
Message-ID: <628d1651003221834g543e3e6cl4ea39c0886cb4ba1@mail.gmail.com> (raw)
In-Reply-To: <4BA7A3CF.8070503@trash.net>
> I can see that the size might cause an overflow in the addition with
> sizeof(struct ipt_get_entries)
That's the integer overflow i pointed.
get.size is copy from the user space, it can be set as 0x7fffffff,
addition with sizeof(struct ipt_get_entries) can be overflow.
if (*len != sizeof(struct ipt_get_entries) + get.size) {
duprintf("get_entries: %u != %zu\n",
*len, sizeof(get) + get.size);
return -EINVAL;
}
so, check get.size max value before addition with sizeof(struct
ipt_get_entries) to prevent the integer overflow.
next prev parent reply other threads:[~2010-03-23 1:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 14:32 [PATCH] Netfilter: Fix integer overflow in net/ipv6/netfilter/ip6_tables.c wzt.wzt
2010-03-22 17:07 ` Patrick McHardy
2010-03-23 1:34 ` wzt wzt [this message]
2010-03-23 2:29 ` Xiaotian Feng
2010-03-23 2:37 ` wzt wzt
2010-03-23 3:04 ` Jan Engelhardt
2010-03-23 3:48 ` wzt wzt
2010-03-23 4:49 ` Xiaotian Feng
2010-03-23 5:49 ` wzt wzt
2010-03-23 3:05 ` Xiaotian Feng
2010-03-23 3:11 ` wzt wzt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=628d1651003221834g543e3e6cl4ea39c0886cb4ba1@mail.gmail.com \
--to=wzt.wzt@gmail.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).