* [ANNOUNCE] ipset 7.18 released
@ 2023-09-19 18:26 Jozsef Kadlecsik
2023-09-20 11:20 ` Jan Engelhardt
0 siblings, 1 reply; 6+ messages in thread
From: Jozsef Kadlecsik @ 2023-09-19 18:26 UTC (permalink / raw)
To: netfilter, netfilter-devel
Hi,
I'm happy to announce ipset 7.18, which brings a few fixes, backports,
tests suite fixes and json output support.
Userspace changes:
- Add json output to list command (Thomas Oberhammer)
- tests: hash:ip,port.t: Replace VRRP by GRE protocol (Phil Sutter)
- tests: hash:ip,port.t: 'vrrp' is printed as 'carp' (Phil Sutter)
- tests: cidr.sh: Add ipcalc fallback (Phil Sutter)
- tests: xlate: Make test input valid (Phil Sutter)
- tests: xlate: Test built binary by default (Phil Sutter)
- xlate: Drop dead code (Phil Sutter)
- xlate: Fix for fd leak in error path (Phil Sutter)
- configure.ac: fix bashisms (Sam James)
- lib/Makefile.am: fix pkgconfig dir (Sam James)
Kernel part changes:
- netfilter: ipset: Fix race between IPSET_CMD_CREATE and IPSET_CMD_SWAP
(reported by Kyle Zeng)
- netfilter: ipset: add the missing IP_SET_HASH_WITH_NET0 macro for
ip_set_hash_netportnet.c (Kyle Zeng)
- compatibility: handle strscpy_pad()
- netfilter: ipset: refactor deprecated strncpy (Justin Stitt)
- netfilter: ipset: remove rcu_read_lock_bh pair from ip_set_test
(Florian Westphal)
- netfilter: ipset: Replace strlcpy with strscpy (Azeem Shaikh)
- netfilter: ipset: Add schedule point in call_ad(). (Kuniyuki Iwashima)
- net: Kconfig: fix spellos (Randy Dunlap)
- netfilter: ipset: Fix overflow before widen in the bitmap_ip_create()
function. (Gavrilov Ilia)
You can download the source code of ipset from:
https://ipset.netfilter.org
git://git.netfilter.org/ipset.git
Best regards,
Jozsef
-
E-mail: kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.hu
PGP key: https://wigner.hu/~kadlec/pgp_public_key.txt
Address: Wigner Research Centre for Physics
H-1525 Budapest 114, POB. 49, Hungary
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [ANNOUNCE] ipset 7.18 released
2023-09-19 18:26 [ANNOUNCE] ipset 7.18 released Jozsef Kadlecsik
@ 2023-09-20 11:20 ` Jan Engelhardt
2023-09-20 11:30 ` Jan Engelhardt
2023-09-21 6:56 ` Jozsef Kadlecsik
0 siblings, 2 replies; 6+ messages in thread
From: Jan Engelhardt @ 2023-09-20 11:20 UTC (permalink / raw)
To: Jozsef Kadlecsik; +Cc: netfilter, netfilter-devel
On Tuesday 2023-09-19 20:26, Jozsef Kadlecsik wrote:
>
>I'm happy to announce ipset 7.18, which brings a few fixes, backports,
>tests suite fixes and json output support.
The installation of the pkgconfig file is now broken.
> - lib/Makefile.am: fix pkgconfig dir (Sam James)
Aaaaagh.. that change completely broke installation and must be reverted.
[ 44s] RPM build errors:
[ 44s] Installed (but unpackaged) file(s) found:
[ 44s] /usr/usr/lib64/pkgconfig/libipset.pc
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ANNOUNCE] ipset 7.18 released
2023-09-20 11:20 ` Jan Engelhardt
@ 2023-09-20 11:30 ` Jan Engelhardt
2023-09-20 12:50 ` Florian Westphal
2023-09-21 6:56 ` Jozsef Kadlecsik
1 sibling, 1 reply; 6+ messages in thread
From: Jan Engelhardt @ 2023-09-20 11:30 UTC (permalink / raw)
To: Jozsef Kadlecsik; +Cc: netfilter, netfilter-devel
On Wednesday 2023-09-20 13:20, Jan Engelhardt wrote:
>On Tuesday 2023-09-19 20:26, Jozsef Kadlecsik wrote:
>>
>>I'm happy to announce ipset 7.18, which brings a few fixes, backports,
>>tests suite fixes and json output support.
>
>The installation of the pkgconfig file is now broken.
>
>> - lib/Makefile.am: fix pkgconfig dir (Sam James)
>
>Aaaaagh.. that change completely broke installation and must be reverted.
commit 326932be0c4f47756f9809cad5a103ac310f700d
Author: Sam James <sam@gentoo.org>
Date: Sat Jan 28 19:23:54 2023 +0100
lib/Makefile.am: fix pkgconfig dir
Signed-off-by: Sam James <sam@gentoo.org>
Signed-off-by: Jozsef Kadlecsik <kadlec@netfilter.org>
Can I just take a moment to vent about this some more.
The change is, in the words of another Linux developer, utter garbage.
${libdir} contains ${prefix} and did so for eternities.
The commit message is utter garbage too, because it does not
even try to make an argument to even _have_ the change in the
first place. Allowing such an underdocumented change is a
failure in the review process itself.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [ANNOUNCE] ipset 7.18 released
2023-09-20 11:30 ` Jan Engelhardt
@ 2023-09-20 12:50 ` Florian Westphal
2023-09-20 13:03 ` Sam James
0 siblings, 1 reply; 6+ messages in thread
From: Florian Westphal @ 2023-09-20 12:50 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: Jozsef Kadlecsik, netfilter, netfilter-devel, sam
Jan Engelhardt <jengelh@inai.de> wrote:
You might want to CC author of that change.
> On Wednesday 2023-09-20 13:20, Jan Engelhardt wrote:
> >On Tuesday 2023-09-19 20:26, Jozsef Kadlecsik wrote:
> >>
> >>I'm happy to announce ipset 7.18, which brings a few fixes, backports,
> >>tests suite fixes and json output support.
> >
> >The installation of the pkgconfig file is now broken.
> >
> >> - lib/Makefile.am: fix pkgconfig dir (Sam James)
> >
> >Aaaaagh.. that change completely broke installation and must be reverted.
>
> commit 326932be0c4f47756f9809cad5a103ac310f700d
> Author: Sam James <sam@gentoo.org>
> Date: Sat Jan 28 19:23:54 2023 +0100
>
> lib/Makefile.am: fix pkgconfig dir
>
> Signed-off-by: Sam James <sam@gentoo.org>
> Signed-off-by: Jozsef Kadlecsik <kadlec@netfilter.org>
>
> Can I just take a moment to vent about this some more.
> The change is, in the words of another Linux developer, utter garbage.
> ${libdir} contains ${prefix} and did so for eternities.
>
> The commit message is utter garbage too, because it does not
> even try to make an argument to even _have_ the change in the
> first place. Allowing such an underdocumented change is a
> failure in the review process itself.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [ANNOUNCE] ipset 7.18 released
2023-09-20 12:50 ` Florian Westphal
@ 2023-09-20 13:03 ` Sam James
0 siblings, 0 replies; 6+ messages in thread
From: Sam James @ 2023-09-20 13:03 UTC (permalink / raw)
To: Florian Westphal
Cc: Jan Engelhardt, Jozsef Kadlecsik, netfilter, netfilter-devel
> On 20 Sep 2023, at 13:51, Florian Westphal <fw@strlen.de> wrote:
>
> Jan Engelhardt <jengelh@inai.de> wrote:
>
> You might want to CC author of that change.
>
Yeah, happy to fix my error - although being polite wouldn't go amiss.
>>> On Wednesday 2023-09-20 13:20, Jan Engelhardt wrote:
>>> On Tuesday 2023-09-19 20:26, Jozsef Kadlecsik wrote:
>>>>
>>>> I'm happy to announce ipset 7.18, which brings a few fixes, backports,
>>>> tests suite fixes and json output support.
>>>
>>> The installation of the pkgconfig file is now broken.
>>>
>>>> - lib/Makefile.am: fix pkgconfig dir (Sam James)
>>>
>>> Aaaaagh.. that change completely broke installation and must be reverted.
>>
>> commit 326932be0c4f47756f9809cad5a103ac310f700d
>> Author: Sam James <sam@gentoo.org>
>> Date: Sat Jan 28 19:23:54 2023 +0100
>>
>> lib/Makefile.am: fix pkgconfig dir
>>
>> Signed-off-by: Sam James <sam@gentoo.org>
>> Signed-off-by: Jozsef Kadlecsik <kadlec@netfilter.org>
>>
>> Can I just take a moment to vent about this some more.
>> The change is, in the words of another Linux developer, utter garbage.
>> ${libdir} contains ${prefix} and did so for eternities.
>>
>> The commit message is utter garbage too, because it does not
>> even try to make an argument to even _have_ the change in the
>> first place. Allowing such an underdocumented change is a
>> failure in the review process itself.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ANNOUNCE] ipset 7.18 released
2023-09-20 11:20 ` Jan Engelhardt
2023-09-20 11:30 ` Jan Engelhardt
@ 2023-09-21 6:56 ` Jozsef Kadlecsik
1 sibling, 0 replies; 6+ messages in thread
From: Jozsef Kadlecsik @ 2023-09-21 6:56 UTC (permalink / raw)
To: Jan Engelhardt, Sam James; +Cc: netfilter, netfilter-devel
Hi Jan,
On Wed, 20 Sep 2023, Jan Engelhardt wrote:
>
> On Tuesday 2023-09-19 20:26, Jozsef Kadlecsik wrote:
> >
> >I'm happy to announce ipset 7.18, which brings a few fixes, backports,
> >tests suite fixes and json output support.
>
> The installation of the pkgconfig file is now broken.
>
> > - lib/Makefile.am: fix pkgconfig dir (Sam James)
>
> Aaaaagh.. that change completely broke installation and must be reverted.
>
> [ 44s] RPM build errors:
> [ 44s] Installed (but unpackaged) file(s) found:
> [ 44s] /usr/usr/lib64/pkgconfig/libipset.pc
Thanks for quickly noticing the issue - the new release is already out.
Even two persons can make mistakes.
Best regards,
Jozsef
-
E-mail : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.hu
PGP key : https://wigner.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics
H-1525 Budapest 114, POB. 49, Hungary
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-21 21:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-19 18:26 [ANNOUNCE] ipset 7.18 released Jozsef Kadlecsik
2023-09-20 11:20 ` Jan Engelhardt
2023-09-20 11:30 ` Jan Engelhardt
2023-09-20 12:50 ` Florian Westphal
2023-09-20 13:03 ` Sam James
2023-09-21 6:56 ` Jozsef Kadlecsik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).