From: Eric Woudstra <ericwouds@gmail.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
Jozsef Kadlecsik <kadlec@netfilter.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH v2 nf-next 0/3] flow offload teardown when layer 2 roaming
Date: Fri, 11 Apr 2025 17:32:57 +0200 [thread overview]
Message-ID: <74e994cb-5ac7-4f91-8f3f-1e355c6d3d8d@gmail.com> (raw)
In-Reply-To: <20250408142848.96281-1-ericwouds@gmail.com>
On 4/8/25 4:28 PM, Eric Woudstra wrote:
> In case of a bridge in the forward-fastpath or bridge-fastpath the fdb is
> used to create the tuple. In case of roaming at layer 2 level, for example
> 802.11r, the destination device is changed in the fdb. The destination
> device of a direct transmitting tuple is no longer valid and traffic is
> send to the wrong destination. Also the hardware offloaded fastpath is not
> valid anymore.
>
> This flowentry needs to be torn down asap. Also make sure that the flow
> entry is not being used, when marked for teardown.
>
> Changes in v2:
> - Unchanged, only tags RFC net-next to PATCH nf-next.
>
> Eric Woudstra (3):
> netfilter: flow: Add bridge_vid member
> netfilter: nf_flow_table_core: teardown direct xmit when destination
> changed
> netfilter: nf_flow_table_ip: don't follow fastpath when marked
> teardown
>
> include/net/netfilter/nf_flow_table.h | 2 +
> net/netfilter/nf_flow_table_core.c | 66 +++++++++++++++++++++++++++
> net/netfilter/nf_flow_table_ip.c | 6 +++
> net/netfilter/nft_flow_offload.c | 3 ++
> 4 files changed, 77 insertions(+)
>
Hi Pablo,
I understand if you are busy, but this patch-set could be reviewed
totally separate from my other submissions. It addresses the issue of L2
roaming for any fastpath.
I'll wait for any other comments, before sending the fix for 'static'.
prev parent reply other threads:[~2025-04-11 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 14:28 [PATCH v2 nf-next 0/3] flow offload teardown when layer 2 roaming Eric Woudstra
2025-04-08 14:28 ` [PATCH v2 nf-next 1/3] netfilter: flow: Add bridge_vid member Eric Woudstra
2025-04-08 14:28 ` [PATCH v2 nf-next 2/3] netfilter: nf_flow_table_core: teardown direct xmit when destination changed Eric Woudstra
2025-04-11 10:23 ` Simon Horman
2025-04-08 14:28 ` [PATCH v2 nf-next 3/3] netfilter: nf_flow_table_ip: don't follow fastpath when marked teardown Eric Woudstra
2025-04-11 15:32 ` Eric Woudstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74e994cb-5ac7-4f91-8f3f-1e355c6d3d8d@gmail.com \
--to=ericwouds@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox