Re: [PATCH nft v2 0/5] add infrastructure for unit tests

[Thomas Haller <thaller@redhat.com>]

On Sun, 2023-11-05 at 16:08 +0100, Thomas Haller wrote:
> Changes to v1:
> 
> - rename some `make targets`
> - add `make check-unit` to alias `make check-TESTS`. These targets
>   run the tests hooked up as "TESTS=" (which for now are the tests
>   in tests/unit).
> - improve commit messages and various minor code changes.
> 
> Thomas Haller (5):
>   build: add basic "check-{local,more,all}" and "build-all" make
> targets
>   build: add `make check-build` to run `./tests/build/run-tests.sh`
>   build: add `make check-tree` to check consistency of source tree
>   build: cleanup if-blocks for conditional compilation in
> "Makefile.am"
>   tests/unit: add unit tests for libnftables
> 
>  .gitignore                           |  15 +-
>  Makefile.am                          | 134 ++++++++++++---
>  src/.gitignore                       |   5 -
>  tests/unit/nft-test.h                |  14 ++
>  tests/unit/test-libnftables-static.c |  16 ++
>  tests/unit/test-libnftables.c        |  21 +++
>  tools/test-runner.sh                 | 235
> +++++++++++++++++++++++++++
>  7 files changed, 412 insertions(+), 28 deletions(-)
>  create mode 100644 tests/unit/nft-test.h
>  create mode 100644 tests/unit/test-libnftables-static.c
>  create mode 100644 tests/unit/test-libnftables.c
>  create mode 100755 tools/test-runner.sh


Hi Pablo,

any concerns about this? Could it be merged?

Thank you,
Thomas