From: Thomas Haller <thaller@redhat.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: NetFilter <netfilter-devel@vger.kernel.org>,
Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH nft v3 1/1] tests/shell: sanitize "handle" in JSON output
Date: Wed, 22 Nov 2023 11:44:54 +0100 [thread overview]
Message-ID: <8a1e3a2451a770d49a9e130103b8a657e9c23c18.camel@redhat.com> (raw)
In-Reply-To: <ZV3ZkD0Yi15ICNZT@calendula>
On Wed, 2023-11-22 at 11:36 +0100, Pablo Neira Ayuso wrote:
> On Tue, Nov 21, 2023 at 02:22:54PM +0100, Thomas Haller wrote:
> > The "handle" in JSON output is not stable. Sanitize/normalize to
> > zero.
> >
> > Adjust the sanitize code, and regenerate the .json-nft files.
>
> Applied, thanks.
>
> I had to adjust a json dump, this diff is not so difficult:
Hi,
Hm. The json dump of the patch was generated.
If you had to "adjust" a dump, does that mean that the output is not
stable?
In that case, the .json-nft file should be removed instead (and the
cause for the difference investigated, fixed, and the dump-re-added).
Thomas
next prev parent reply other threads:[~2023-11-22 10:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 17:18 [PATCH nft 1/1] tests/shell: sanitize "handle" in JSON output Thomas Haller
2023-11-18 2:36 ` Phil Sutter
2023-11-21 12:10 ` Thomas Haller
2023-11-21 12:39 ` Phil Sutter
2023-11-21 12:58 ` Thomas Haller
2023-11-21 13:40 ` Phil Sutter
2023-11-21 14:35 ` Thomas Haller
2023-11-21 15:19 ` Phil Sutter
2023-11-21 12:45 ` Pablo Neira Ayuso
[not found] ` <20231121132331.3401846-1-thaller@redhat.com>
2023-11-22 10:36 ` [PATCH nft v3 " Pablo Neira Ayuso
2023-11-22 10:44 ` Thomas Haller [this message]
2023-11-22 11:22 ` Pablo Neira Ayuso
2023-11-22 12:16 ` Thomas Haller
2023-11-22 12:32 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a1e3a2451a770d49a9e130103b8a657e9c23c18.camel@redhat.com \
--to=thaller@redhat.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).