Re: [PATCH] netfilter: ipv4: fix NULL dereference

["Liping Zhang" <zlpwmdx@163.com>]

At 2016-03-25 04:22:05, "Pablo Neira Ayuso" <pablo@netfilter.org> wrote:
>
>Could you also pass net as parameter to synproxy_send_server_syn() ?
>
>par->net provides this from synproxy_tg4().

Not pass the net but replace the first parameter 'snet' with 'net' seems better?
snet is only used in synproxy_recv_client_ack->synproxy_send_server_syn call path,
and in other call path, actually we only need net,  and we can call synproxy_pernet(net)
to get the snet.

like follows:
-synproxy_send_server_syn(const struct synproxy_net *snet,
+synproxy_send_server_syn(struct net *net,

-synproxy_recv_client_ack(const struct synproxy_net *snet,
+synproxy_recv_client_ack(struct net *net,
                         const struct sk_buff *skb, const struct tcphdr *th,
                         struct synproxy_options *opts, u32 recv_seq)  {
+       struct synproxy_net *snet = synproxy_pernet(net);

>
>Thanks.