From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 641446BB33 for ; Thu, 8 Feb 2024 09:13:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707383612; cv=none; b=p/FBK+fWdEkMkLNfdXRzAJD1sJcCIWayIfdAZZoAnJY3KLYKPuscOqvaJNX8ccqWQ3FTGxb9TeA3jxP3vpEXYSAg+hvgs58hvICsfcRcvciRizfp9FvNziogZS3O9JzJn+CQannWzdJLnm1fjt2K7P6F6pzRcgzf1ItOnWToXgk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707383612; c=relaxed/simple; bh=9zF3Ezo/ANeNdJ+Xuckqw6QcIqvxJGp+6Gvua+HRf2k=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=PFa0y0zaG+MuTbw9dSfh28IZDrCiFRmL1IAn+95gdN+TNI34WLrBzEVBCkre3P8RHSu8w5/5A+M2dmo44ya8T35Z7jm5huBHZIVfWxLL/ekvDsSTYOfn2xfd78wLW6Lt+Usv6Bvytt+Kz+Lfl62lj7Kx2suW/ck3845+cHbgO6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MRdbmRO3; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MRdbmRO3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707383609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8xfC+q4cOFnaGgSvA+t+4KzdCijigbr85ElJBIo8Rvc=; b=MRdbmRO3Ov7oN+PhWNP80S3bP18yQdsxplopDPh1LBVJ3g01lwued/Wp/BQ85CCi7jlFnQ M4p7Yrym6eQRa9tMIrYNSW48E+U+ilzhxNviVqGP/GI/kOiZ5ScP5ZxAMuztB1s2/0BObK WUCtdW4TWcJrhcIF/ASLZZx2u9lInI4= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-146-jMvTFEsAMLWNEJM5uaex2g-1; Thu, 08 Feb 2024 04:13:28 -0500 X-MC-Unique: jMvTFEsAMLWNEJM5uaex2g-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5115ef6339bso546295e87.1 for ; Thu, 08 Feb 2024 01:13:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707383606; x=1707988406; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8xfC+q4cOFnaGgSvA+t+4KzdCijigbr85ElJBIo8Rvc=; b=XlA2bR4a9z7CFicij/yHP8CLMDpUo2SuVy9FM9fBOQgWUSW67EiOBFhzsw6aDzIoxJ 72Gtp+yo+nw9HnbdEHKLXp8uHUYf1tDk9dvKkFcwgcxH8FHOxoSgfHfiyt3A3/JpXAcT Zi03LjR8U5CMgAM2Yg5Y9UI48F2eSoNbLSvT/xTNdWpaV/5tPg340d19HI059CScd1v0 67GPrQvHtfUNPweIwPUvQez9Ypv/rHNT5QrJzdLfpWm0CFmZsKxjg7APixxMSwudAlAC eadpBwMyTHCJOdpfgQwjfRHbxLX+nl8/L+BRAVYFio6i9EEjJL7eFTbqb989k7mKG8Qi EHmg== X-Forwarded-Encrypted: i=1; AJvYcCXGYR2Tas5RWQ/s6q8AFsqoWteV/YTGoVfa8y/bJGbtb998/uidlVrKDxklW5hXK9pPf/WgrZt8pVe3OBgcC0PI+Sq+ZWZDeId71SD72842 X-Gm-Message-State: AOJu0Yy60fhW6bhQiDmGPjYvuAu1ILSkJ7CcPIE+BrrnDtFnJnYBVEwe gr4ZH+uHQZ+XkktjY5GUNoWSQMCP1IgejUxzDu7lI5XSLpmsMYc8gdlPN2A7ibGkpiPef09jqbn 2YIfkwGaeoz9H0ONbEX+Zkup8b7T5uV7E4yY8+Gv+jQUiLG7VVnA/7macTcoI6VpV1Q== X-Received: by 2002:a19:2d44:0:b0:511:68e4:63e4 with SMTP id t4-20020a192d44000000b0051168e463e4mr2102372lft.0.1707383606722; Thu, 08 Feb 2024 01:13:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IFVtqHLyl7hcBVaJAT815mSdtPH4e0N+slNB/TVuSIbXh6eBqXXUTvP4ycP6blBm5o3MXi3Lg== X-Received: by 2002:a19:2d44:0:b0:511:68e4:63e4 with SMTP id t4-20020a192d44000000b0051168e463e4mr2102351lft.0.1707383606375; Thu, 08 Feb 2024 01:13:26 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXf/lx21ANjK8EG9hJjJ6tErxxihVuRB3cM5Z+xV+VE4iRgP1zDilhBeXz1hlvl5t7QveGNmKltEOSF9Hgmsjea4HG787YyC7gGeeLAbqio9UE9vBbopyVtK+noOzPZO7ddkRTX6fnAph9BCTxxGGcxdjEHHvfZdJIvNq1Vy2DLHcZj1wWzZxd/oPtn4jJ1VzM0QYhM2Bqf741ydg== Received: from gerbillo.redhat.com (146-241-238-112.dyn.eolo.it. [146.241.238.112]) by smtp.gmail.com with ESMTPSA id r14-20020a05600c458e00b0040fdc7f4fcdsm1072462wmo.4.2024.02.08.01.13.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 01:13:25 -0800 (PST) Message-ID: <8be7ca31e76e24e358db977524845a9d36b35e55.camel@redhat.com> Subject: Re: [PATCH net 13/13] netfilter: nft_set_pipapo: remove scratch_aligned pointer From: Paolo Abeni To: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org, edumazet@google.com, fw@strlen.de Date: Thu, 08 Feb 2024 10:13:24 +0100 In-Reply-To: <20240207233726.331592-14-pablo@netfilter.org> References: <20240207233726.331592-1-pablo@netfilter.org> <20240207233726.331592-14-pablo@netfilter.org> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2024-02-08 at 00:37 +0100, Pablo Neira Ayuso wrote: > diff --git a/net/netfilter/nft_set_pipapo.h b/net/netfilter/nft_set_pipap= o.h > index 144b186c4caf..e5f67c5cf30a 100644 > --- a/net/netfilter/nft_set_pipapo.h > +++ b/net/netfilter/nft_set_pipapo.h > @@ -133,10 +133,12 @@ struct nft_pipapo_field { > /** > * struct nft_pipapo_scratch - percpu data used for lookup and matching > * @map_index Current working bitmap index, toggled between field matche= s > + * @align_off Offset to get the originally allocated address (only if v2 is coming) Same here, ':' is needed for kdoc's sake. Cheers, Paolo