From: David Ahern <dsahern@kernel.org>
To: Phil Sutter <phil@nwl.cc>, Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>,
Guillaume Nault <gnault@redhat.com>,
Miaohe Lin <linmiaohe@huawei.com>
Subject: Re: [nf-next PATCH 2/2] netfilter: rpfilter/fib: Populate flowic_l3mdev field
Date: Wed, 5 Oct 2022 13:29:21 -0600 [thread overview]
Message-ID: <8cfd5bd0-e8e2-2d63-c8c1-267a71a81b7c@kernel.org> (raw)
In-Reply-To: <20221005160705.8725-2-phil@nwl.cc>
On 10/5/22 10:07 AM, Phil Sutter wrote:
> Use the introduced field for correct operation with VRF devices instead
> of conditionally overwriting flowic_oif. This is a partial revert of
> commit b575b24b8eee3 ("netfilter: Fix rpfilter dropping vrf packets by
> mistake"), implementing a simpler solution.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
> net/ipv4/netfilter/ipt_rpfilter.c | 2 +-
> net/ipv4/netfilter/nft_fib_ipv4.c | 2 +-
> net/ipv6/netfilter/ip6t_rpfilter.c | 9 +++------
> net/ipv6/netfilter/nft_fib_ipv6.c | 5 ++---
> 4 files changed, 7 insertions(+), 11 deletions(-)
>
LGTM
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2022-10-05 19:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 16:07 [nf-next PATCH 1/2] selftests: netfilter: Test reverse path filtering Phil Sutter
2022-10-05 16:07 ` [nf-next PATCH 2/2] netfilter: rpfilter/fib: Populate flowic_l3mdev field Phil Sutter
2022-10-05 19:29 ` David Ahern [this message]
2022-10-06 9:04 ` Guillaume Nault
2022-10-06 10:09 ` [nf-next PATCH 1/2] selftests: netfilter: Test reverse path filtering Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cfd5bd0-e8e2-2d63-c8c1-267a71a81b7c@kernel.org \
--to=dsahern@kernel.org \
--cc=fw@strlen.de \
--cc=gnault@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).