netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Louis Sautier <sautier.louis@gmail.com>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH] xtables-compat-restore: fix translation of mangle's OUTPUT
Date: Sun, 10 Sep 2017 02:39:51 +0200	[thread overview]
Message-ID: <90185d38-8713-2a2a-6d47-c3db17f83dcb@gmail.com> (raw)


[-- Attachment #1.1.1: Type: text/plain, Size: 319 bytes --]

Hello,
I noticed that the iptables-restore-translate tool does not properly
translate the OUTPUT chain from the mangle table. It creates a filter
chain when it should be creating a route chain.
Here is a rather simple patch that should fix the issue.

Please CC me, I'm not subscribed.

Kind regards,

Louis

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1.2: 0001-xtables-compat-restore-fix-translation-of-mangle-s-O.patch --]
[-- Type: text/x-patch; name="0001-xtables-compat-restore-fix-translation-of-mangle-s-O.patch", Size: 930 bytes --]

From 4eb328c7756044279243419dd3f116754f924a3e Mon Sep 17 00:00:00 2001
From: Louis Sautier <sautier.louis@gmail.com>
Date: Sun, 10 Sep 2017 02:13:18 +0200
Subject: [PATCH] xtables-compat-restore: fix translation of mangle's OUTPUT
 chain

This chain should be translated as a route chain, not as a filter chain.
---
 iptables/xtables-translate.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/iptables/xtables-translate.c b/iptables/xtables-translate.c
index 3e6c7051..4f6a9caf 100644
--- a/iptables/xtables-translate.c
+++ b/iptables/xtables-translate.c
@@ -357,6 +357,8 @@ static int xlate_chain_set(struct nft_handle *h, const char *table,
 
 	if (strcmp(table, "nat") == 0)
 		type = "nat";
+	else if (strcmp(table, "mangle") == 0 && strcmp(chain, "OUTPUT") == 0)
+		type = "route";
 
 	printf("add chain %s %s %s { type %s ",
 	       family2str[h->family], table, chain, type);
-- 
2.14.1


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2017-09-10  0:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-10  0:39 Louis Sautier [this message]
2017-09-10 18:35 ` [PATCH] xtables-compat-restore: fix translation of mangle's OUTPUT Louis Sautier
2017-09-10 20:05   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90185d38-8713-2a2a-6d47-c3db17f83dcb@gmail.com \
    --to=sautier.louis@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).