From: Vasily Averin <vvs@virtuozzo.com>
To: coreteam@netfilter.org, netfilter-devel@vger.kernel.org
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>
Subject: [PATCH v2 1/4] ct_cpu_seq_next should increase position index
Date: Tue, 25 Feb 2020 10:05:47 +0300 [thread overview]
Message-ID: <944091db-7b0d-2e5b-bc0a-9c07caf84b40@virtuozzo.com> (raw)
In-Reply-To: <497a82c1-7b6a-adf4-a4ce-df46fe436aae@virtuozzo.com>
If .next function does not change position index,
following .show function will repeat output related
to current position index.
Cc: stable@vger.kernel.org
Fixes: 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code ...")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=206283
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
---
net/netfilter/nf_conntrack_standalone.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nf_conntrack_standalone.c b/net/netfilter/nf_conntrack_standalone.c
index 410809c..4912069 100644
--- a/net/netfilter/nf_conntrack_standalone.c
+++ b/net/netfilter/nf_conntrack_standalone.c
@@ -411,7 +411,7 @@ static void *ct_cpu_seq_next(struct seq_file *seq, void *v, loff_t *pos)
*pos = cpu + 1;
return per_cpu_ptr(net->ct.stat, cpu);
}
-
+ (*pos)++;
return NULL;
}
--
1.8.3.1
next prev parent reply other threads:[~2020-02-25 7:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 7:25 [PATCH 0/4] netfilter: seq_file .next functions should increase position index Vasily Averin
2020-02-25 7:05 ` [PATCH v2 " Vasily Averin
2020-03-04 1:26 ` Pablo Neira Ayuso
2020-02-25 7:05 ` Vasily Averin [this message]
2020-02-25 7:05 ` [PATCH v2 2/4] synproxy_cpu_seq_next " Vasily Averin
2020-02-25 7:06 ` [PATCH v2 3/4] recent_seq_next " Vasily Averin
2020-02-25 7:07 ` [PATCH v2 4/4] xt_mttg_seq_next " Vasily Averin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=944091db-7b0d-2e5b-bc0a-9c07caf84b40@virtuozzo.com \
--to=vvs@virtuozzo.com \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).