From: Jozsef Kadlecsik <kadlec@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: "Maciej Żenczykowski" <zenczykowski@gmail.com>,
"Netfilter Development Mailinglist"
<netfilter-devel@vger.kernel.org>,
"Pablo Neira Ayuso" <pablo@netfilter.org>
Subject: Re: Android boot failure with 6.12
Date: Sat, 11 Jan 2025 17:51:02 +0100 (CET) [thread overview]
Message-ID: <94f5258d-c40a-4bcf-0e1e-f791d5fdb9cf@netfilter.org> (raw)
In-Reply-To: <20250111140543.GB14912@breakpoint.cc>
Hi Florian,
On Sat, 11 Jan 2025, Florian Westphal wrote:
> > Also, why the "mark" match was not split into NFPROTO_IPV4,
> > NFPROTO_ARP, NFPROTO_IPV6 explicitly (and other matches where the
> > target was split)?
>
> mark match is fine, afaics. Whats the concern?
>
> The target got split because ebtables EBT_CONTINUE isn't equal to
> XT_CONTINUE, so it won't do the right thing.
I have just reread the description of your patch "netfilter: xtables:
avoid NFPROTO_UNSPEC where needed" and now I see why the match is fine as
is. Thanks!
Best regards,
Jozsef
--
E-mail : kadlec@netfilter.org, kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.hu
Address: Wigner Research Centre for Physics
H-1525 Budapest 114, POB. 49, Hungary
next prev parent reply other threads:[~2025-01-11 16:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 22:20 Android boot failure with 6.12 Maciej Żenczykowski
2025-01-10 22:23 ` Maciej Żenczykowski
2025-01-10 22:28 ` Maciej Żenczykowski
2025-01-10 22:36 ` Maciej Żenczykowski
2025-01-11 13:31 ` Jozsef Kadlecsik
2025-01-11 14:05 ` Florian Westphal
2025-01-11 16:51 ` Jozsef Kadlecsik [this message]
2025-01-11 14:17 ` Pablo Neira Ayuso
2025-01-11 16:53 ` Jozsef Kadlecsik
2025-01-11 13:57 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94f5258d-c40a-4bcf-0e1e-f791d5fdb9cf@netfilter.org \
--to=kadlec@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).