From: "Igor 'Lo' (И.L.)" <bombsiteunrested@gmail.com>
To: netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] netfilter: nf_ct_tcp: better handling for SYN retransmissions after SYN+ACK
Date: Sun, 27 Feb 2011 04:08:42 +0200 [thread overview]
Message-ID: <AANLkTi=yip8CG+1oC0s_Wb8u_ymw2F1UnLdBy7jNHLS3@mail.gmail.com> (raw)
In-Reply-To: <4D699421.4070309@netfilter.org>
It's a bit off-topic, but can it be recommended to hack into nf_ct_tcp
somehow changing it's structure to assign each connection unique id
and pass it with each retransmission event detected to nfqueue -
without setting too complicated skbuffs / iptables rules? Or this is
considered as dirty hacking and should be implemented other way?
Reasons to do this: currently, trying to set up a small NFQUEUE-based
program that will modify data in TCP streams, that causes
retransmissions due to changed size thus requires SEQ/ACK tuning (and
as far as I suspect, something deeper than a filter table affects the
idea, but it's the separate question) and the network-caused
retransmissions are a bit of pain to track.
On 27 February 2011 02:00, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>
> On 27/02/11 00:42, Pablo Neira Ayuso wrote:
> > On 26/02/11 22:45, Jozsef Kadlecsik wrote:
> >> On Sat, 26 Feb 2011, Pablo Neira Ayuso wrote:
> >>> I have test it here, it works fine. Let me know if you're OK with it.
> >>
> >> The patch looks OK but I think Changli Gao is also right and it'd be
> >> simpler to set the [reply][synack][SR] state to sIG. What do you think?
> >
> > I read his email before leaving and after I made the new patch.
> >
> > Indeed, his idea is simpler, here's a new patch. I tested it here, it
> > works fine.
> >
> > Patrick, please apply!
>
> Hm, I forgot to include the description. New patch attached.
--
С уважением,
Игорь
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-02-27 2:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 3:32 [PATCH] improvement for TCP connection tracking Pablo Neira Ayuso
2011-02-26 3:33 ` [PATCH] netfilter: nf_ct_tcp: better handling for SYN retransmissions after SYN+ACK Pablo Neira Ayuso
2011-02-26 6:15 ` Changli Gao
2011-02-26 18:30 ` Jozsef Kadlecsik
2011-02-26 20:11 ` Pablo Neira Ayuso
2011-02-26 21:45 ` Jozsef Kadlecsik
2011-02-26 23:42 ` Pablo Neira Ayuso
2011-02-27 0:00 ` Pablo Neira Ayuso
2011-02-27 2:08 ` Igor 'Lo' (И.L.) [this message]
2011-02-27 15:22 ` Patrick McHardy
2011-02-27 17:28 ` Jozsef Kadlecsik
2011-02-28 17:04 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=yip8CG+1oC0s_Wb8u_ymw2F1UnLdBy7jNHLS3@mail.gmail.com' \
--to=bombsiteunrested@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).