netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Changli Gao <xiaosuo@gmail.com>
To: Valentijn Sessink <valentijn@sessink.nl>
Cc: netfilter-devel@vger.kernel.org, Patrick McHardy <kaber@trash.net>
Subject: Re: [Fwd: [Bug 29332] xt_recent handles "! --update" wrong]
Date: Sun, 13 Mar 2011 23:00:38 +0800	[thread overview]
Message-ID: <AANLkTikS0zi2ncD_aMNQdT+fxjhUQWKihTDAShChT1A_@mail.gmail.com> (raw)
In-Reply-To: <4D5E783E.6000600@sessink.nl>

On Fri, Feb 18, 2011 at 9:46 PM, Valentijn Sessink <valentijn@sessink.nl> wrote:
> Hello Netfilter devs,
>
> As per request from Patrick McHardy:
>> https://bugzilla.kernel.org/show_bug.cgi?id=29332
>> --- Comment #3 from Patrick McHardy <kaber@trash.net>
>> Please submit your patch to netfilter-devel@vger.kernel.org so others
>> can have a look as well.
>
> ... please find attached my proposed patch - free cleanup included.
>
> As noted in Bugzilla, I'm by no means a programmer, so please take my
> patch with a grain of salt. Also, I do realise that fixing bugs and
> cleaning up should probably not be mixed, so you might want to just use
> the simple (but IMHO stupid) fix:
>
> (info->check_set & XT_RECENT_UPDATE && (ret ^ info->invert)))

IMHO, we should keep bugfix patches as clean as possible, so I prefer
the above fix. Thanks.

>
> I hope the problem is trivial enough to not present a test case, but if
> you want one, I'll make one.
>
> Please feel free to throw my patch away and build something more
> sensible ;-)
>

-- 
Regards,
Changli Gao(xiaosuo@gmail.com)

      reply	other threads:[~2011-03-13 15:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-18 13:46 [Fwd: [Bug 29332] xt_recent handles "! --update" wrong] Valentijn Sessink
2011-03-13 15:00 ` Changli Gao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikS0zi2ncD_aMNQdT+fxjhUQWKihTDAShChT1A_@mail.gmail.com \
    --to=xiaosuo@gmail.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=valentijn@sessink.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).