From mboxrd@z Thu Jan 1 00:00:00 1970 From: Changli Gao Subject: Re: [PATCH 6/8] netfilter: ipt_CLUSTERIP: use proto_ports_offset() to support AH message Date: Wed, 18 Aug 2010 14:16:22 +0800 Message-ID: References: <1282107952-3624-1-git-send-email-xiaosuo@gmail.com> <1282111708.2456.11.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Patrick McHardy , "David S. Miller" , netfilter-devel@vger.kernel.org, netdev@vger.kernel.org To: Eric Dumazet Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:36448 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105Ab0HRGQn (ORCPT ); Wed, 18 Aug 2010 02:16:43 -0400 In-Reply-To: <1282111708.2456.11.camel@edumazet-laptop> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Wed, Aug 18, 2010 at 2:08 PM, Eric Dumazet wrote: > > This added test is not documented in your Changelog > > Please dont add such things not telling why you do it. > > I am not sure it is needed here, I dont know ipt_CLUSTERIP, but dont > defrag takes place before it ? You are right. ipt_CLUSTERIP relies on ip_conntrack, and defrag takes place before it. Thanks. I'll post an update. -- Regards, Changli Gao(xiaosuo@gmail.com)